Skip to content

feature: support icon on individual callouts #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hneutr opened this issue Oct 2, 2024 · 2 comments
Closed

feature: support icon on individual callouts #194

hneutr opened this issue Oct 2, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@hneutr
Copy link

hneutr commented Oct 2, 2024

Is your feature request related to a problem? Please describe.

Callouts are great for leveraging the plugin to apply custom highlights. It would be amazing if individual callouts could specify their own icon parameter, overwriting the one specified in config.quote.icon. This is definitely a minor feature request!

Describe the solution you'd like

Allow callouts to overwrite the icon parameter set in the config.quote.icon.

Describe alternatives you've considered

In my particular use-case, I don't actually want an icon on some callouts. So, an alternative would be allowing callouts to specify that no icon be rendered. Since this can be achieved with quote.icon = '', this doesn't feel like a particularly good solution, but it would work.

Additional information

As always, I appreciate the time and effort you put into this plugin — it has genuinely improved my day to day experience with Neovim.

@hneutr hneutr added the enhancement New feature or request label Oct 2, 2024
MeanderingProgrammer added a commit that referenced this issue Oct 3, 2024
## Details

Request: #194

This adds an optional `quote_icon` field for each callout.

If provided this value will be used instead of the `quote.icon` value.

This means callouts can specify a custom value for the right bar of the quote.
Functions very similar to callout highlight except it is always optional.

Most changes to make this happen are related to splitting the type for
custom checkboxes and custom callouts, which before used the same class.

Now there is a different class for callouts and checkboxes which
impacted context and config normalization.
@MeanderingProgrammer
Copy link
Owner

Added here: 1eb3b74.

For each callout you can now specify a quote_icon value.

If you want no icon to be rendered I would use a space, i.e. quote_icon = ' ', rather than the empty string.

@hneutr
Copy link
Author

hneutr commented Oct 4, 2024

You're awesome. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants