Fix checkbox indent #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combination of a list marker and a checkbox is replaced by the virtual text of the checkbox. By this, ```` unchecked = ' ', checked = ' ', ``` would align the indentation of normal bullets and checkboxes, and ``` unchecked = ' ', checked = ' ',. ``` would display the same as before the modification.
|
Hi, thanks for the PR! I went about resolving this in a slightly different way in: 258da4b. Rather than overlaying with spaces I applied a conceal on the list marker before a checkbox, that way the entire line shifts over and we avoid the gap between the checkbox and the text. I originally didn't like that when a cursor enters a line the concealed text pops back up, but turns out there is another option called Hope this does what you were looking for, I appreciate your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was good that the commit e38795f made the list markers invisible, but there was a problem with indentation broken when the list and checkboxes coexisted only by hiding the list markers.
Replacing the combination of list markers and checkboxes with the virtual text of the checkboxes solved the indentation problem.