Skip to content

feat(code): width = block #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

folke
Copy link
Contributor

@folke folke commented Jul 23, 2024

When opts.code.width = 'block'
With an optional opts.code.pad_right

image

@georgeguimaraes
Copy link

georgeguimaraes commented Jul 23, 2024

I really like this UI change as well :)

@folke
Copy link
Contributor Author

folke commented Jul 23, 2024

@MeanderingProgrammer rebased on main.

Copy link
Owner

@MeanderingProgrammer MeanderingProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, changes make sense, just some minor things.

@folke
Copy link
Contributor Author

folke commented Jul 24, 2024

I had to refactor the code a bit, since the Normal block on the right had a higher priority than the diagnostics and would cut them off.
Fixed by setting priority to 0 and by changing the thin border to only render up to width of the block when width = "block"

@MeanderingProgrammer
Copy link
Owner

Looks good, thanks for the details!

@MeanderingProgrammer MeanderingProgrammer merged commit 8aff425 into MeanderingProgrammer:main Jul 24, 2024
@folke
Copy link
Contributor Author

folke commented Jul 24, 2024

Thank you for merging!
I also just merged the LazyVim PR, so markdown.nvim is now the default LazyVim renderer for the markdown extra :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants