Skip to content

Make icon bigger on some terminal by default. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

lkhphuc
Copy link
Contributor

@lkhphuc lkhphuc commented Mar 24, 2024

On some terminal, unicode icons will span 2 cells if the icon is followed by a white space.
This make the icons looks bigger and is comparable to text.

This PR changes the default icons with an explicit space in between. It does not make the rendered text any longer, just make the icons look bigger on supported terminal.
Before/After:
Screenshot 2024-03-24 at 15 58 35
Screenshot 2024-03-24 at 15 58 22

@MeanderingProgrammer
Copy link
Owner

What font / terminal are you using?
I played around with various Mono & Non Mono spaced Nerd Fonts and can't replicate this behavior.
For me the icons are always either the small version (mono spaced fonts) or the larger version (non mono spaced fonts), but the space itself doesn't seem to make a difference.

@lkhphuc
Copy link
Contributor Author

lkhphuc commented Mar 25, 2024

I'm using just the Symbols Nerd Font for the fallback of all my other Mono font on Wezterm.
The relevant setting by default is here: https://wezfurlong.org/wezterm/config/lua/config/allow_square_glyphs_to_overflow_width.html?h=font but I remember other terminals have it too, but I might be wrong.
FWIW other projects set symbols with a space as well https://github.com/LazyVim/LazyVim/blob/9e07a6615a16fafca37a6def86aa8344c09d289a/lua/lazyvim/config/init.lua#L35-L40

MeanderingProgrammer added a commit that referenced this pull request Mar 25, 2024
## Details

Merges in the default headings change from:
#9 by
@lkhphuc.

By adding an extra space certains font / terminal configurations
will be able to render a larger symbol.

Configurations which cannot take advantage of the additional space
will see no change.
@MeanderingProgrammer
Copy link
Owner

Ahh interesting. I was able to replicate it through Wezterm, neat.
I pushed in a change for the headings only in: 8787fdf.
I left the bullet point as is since that didn't seem to do anything.
Thank you!

MeanderingProgrammer added a commit that referenced this pull request Mar 25, 2024
## Details

Merges in the default headings change from:
#9 by
@lkhphuc.

By adding an extra space certains font / terminal configurations
will be able to render a larger symbol.

Configurations which cannot take advantage of the additional space
will see no change.

Co-Authored-By: Phúc H. Lê Khắc <[email protected]>
@MeanderingProgrammer
Copy link
Owner

Sorry, forgot to do the github magic to assign credit correctly.

This change is now in this commit: 38f7cbc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants