[pull] master from airbnb:master

.github/workflows/node.yml

@@ -13,7 +13,7 @@ jobs:
         with:
           versionsAsRoot: true
           type: 'majors'
-          preset: '^10 || ^12 || ^14 || ^16 || >= 17'
+          preset: '^12 || ^14 || ^16 || >= 17'
 
   base:
     needs: [matrix]
@@ -25,11 +25,14 @@ jobs:
       matrix:
         node-version: ${{ fromJson(needs.matrix.outputs.latest) }}
         eslint:
+          - 8
           - 7
-          - 6
-          - 5
         package:
           - eslint-config-airbnb-base
+        exclude:
+          - node-version: 10
+            eslint: 8
+            package: eslint-config-airbnb-base
 
     defaults:
       run:
@@ -40,7 +43,12 @@ jobs:
       - uses: ljharb/actions/node/install@main
         name: 'nvm install ${{ matrix.node-version }} && npm install'
         with:
+          before_install: cd "packages/${{ matrix.package }}"
           node-version: ${{ matrix.node-version }}
+          after_install: |
+            npm install --no-save "eslint@${{ matrix.eslint }}"
+      - run: node -pe "require('eslint/package.json').version"
+        name: 'eslint version'
       - run: npm run travis
       - uses: codecov/codecov-action@v2
 
@@ -54,16 +62,12 @@ jobs:
       matrix:
         node-version: ${{ fromJson(needs.matrix.outputs.latest) }}
         eslint:
+          - 8
           - 7
-          - 6
-          - 5
         package:
           - eslint-config-airbnb
         react-hooks:
-          - ''
-          - 3
-          - 2.3
-          - 1.7
+          - 4
 
     defaults:
       run:
@@ -74,9 +78,12 @@ jobs:
       - uses: ljharb/actions/node/install@main
         name: 'nvm install ${{ matrix.node-version }} && npm install'
         with:
+          before_install: cd "packages/${{ matrix.package }}"
           node-version: ${{ matrix.node-version }}
           after_install: |
             npm install --no-save "eslint@${{ matrix.eslint }}"
+      - run: node -pe "require('eslint/package.json').version"
+        name: 'eslint version'
       - run: npm install --no-save "eslint-plugin-react-hooks@${{ matrix.react-hooks }}"
         if: ${{ matrix.react-hooks > 0}}
       - run: npm run travis
@@ -89,9 +96,8 @@ jobs:
       fail-fast: false
       matrix:
         eslint:
+          - 8
           - 7
-          - 6
-          - 5
         package:
           - eslint-config-airbnb-base
 
@@ -102,13 +108,16 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - uses: ljharb/actions/node/install@main
-        name: 'nvm install ${{ matrix.node-version }} && npm install'
+        name: 'nvm install lts/* && npm install'
         with:
+          before_install: cd "packages/${{ matrix.package }}"
           node-version: lts/*
           after_install: |
             npm install --no-save "eslint@${{ matrix.eslint }}"
+      - run: node -pe "require('eslint/package.json').version"
+        name: 'eslint version'
       - run: npm run pretravis
-      - run: npm run prepublish
+      - run: npm run prepublishOnly
       - run: npm run posttravis
 
   prepublish-react:
@@ -118,16 +127,12 @@ jobs:
       fail-fast: false
       matrix:
         eslint:
+          - 8
           - 7
-          - 6
-          - 5
         package:
           - eslint-config-airbnb
         react-hooks:
-          - ''
-          - 3
-          - 2.3
-          - 1.7
+          - 4
 
     defaults:
       run:
@@ -136,15 +141,18 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - uses: ljharb/actions/node/install@main
-        name: 'nvm install ${{ matrix.node-version }} && npm install'
+        name: 'nvm install lts/* && npm install'
         with:
+          before_install: cd "packages/${{ matrix.package }}"
           node-version: lts/*
           after_install: |
             npm install --no-save "eslint@${{ matrix.eslint }}"
       - run: npm install --no-save "eslint-plugin-react-hooks@${{ matrix.react-hooks }}"
         if: ${{ matrix.react-hooks > 0}}
+      - run: node -pe "require('eslint/package.json').version"
+        name: 'eslint version'
       - run: npm run pretravis
-      - run: npm run prepublish
+      - run: npm run prepublishOnly
       - run: npm run posttravis
 
   node:

css-in-javascript/README.md

@@ -34,7 +34,7 @@
 
   - Use an underscore for modifiers to other styles.
 
-    > Why? Similar to BEM, this naming convention makes it clear that the styles are intended to modify the element preceded by the underscore. Underscores do not need to be quoted, so they are preferred over other characters, such as dashes.
+    > Why? Similar to [BEM](https://getbem.com/introduction/), this naming convention makes it clear that the styles are intended to modify the element preceded by the underscore. Underscores do not need to be quoted, so they are preferred over other characters, such as dashes.
 
     ```js
     // bad

package.json

@@ -40,7 +40,7 @@
   },
   "homepage": "https://github.com/airbnb/javascript",
   "devDependencies": {
-    "markdownlint": "^0.20.4",
-    "markdownlint-cli": "^0.23.2"
+    "markdownlint": "^0.29.0",
+    "markdownlint-cli": "^0.35.0"
   }
 }

packages/eslint-config-airbnb-base/CHANGELOG.md

@@ -1,3 +1,22 @@
+15.0.0 / 2021-11-08
+==================
+ - [breaking] drop eslint < 7, add eslint 8 (#2495)
+ - [breaking] add `exports`
+ - [patch] Improve `function-paren-newline` with `multiline-arguments` option (#2471)
+ - [patch] update default value for complexity (#2420)
+ - [patch] add disabled `no-unsafe-optional-chaining` rule
+ - [patch] arthmetic -> arithmetic (#2341)
+ - [patch] fix spelling of "than" (#2333)
+ - [patch] add `no-nonoctal-decimal-escape` rule
+ - [patch] `import/no-extraneous-dependencies`: Add .eslintrc.js to devDeps (#2329)
+ - [guide] Spread operator => Spread syntax (#2423)
+ - [guide] add references for eslint rules (#2419)
+ - [Docs] HTTP => HTTPS (#2489)
+ - [readme] some updates
+ - [meta] use `prepublishOnly` script for npm 7+
+ - [deps] update `eslint-plugin-import`, `eslint-plugin-react`, `object.entries`
+ - [dev deps] update `@babel/runtime`, `tape`
+
 14.2.1 / 2020-11-06
 ==================
  - [base] `no-restricted-globals`: add better messages (#2320)

packages/eslint-config-airbnb-base/README.md

@@ -1,6 +1,10 @@
-# eslint-config-airbnb-base
+# eslint-config-airbnb-base <sup>[![Version Badge][npm-version-svg]][package-url]</sup>
 
-[![npm version](https://badge.fury.io/js/eslint-config-airbnb-base.svg)](https://badge.fury.io/js/eslint-config-airbnb-base)
+[![npm version](https://badge.fury.io/js/eslint-config-airbnb-base.svg)][package-url]
+
+[![github actions][actions-image]][actions-url]
+[![License][license-image]][license-url]
+[![Downloads][downloads-image]][downloads-url]
 
 This package provides Airbnb's base JS .eslintrc (without React plugins) as an extensible shared config.
 
@@ -79,7 +83,7 @@ Lints ES5 and below. Requires `eslint` and `eslint-plugin-import`.
   Which produces and runs a command like:
 
   ```sh
-  npm install --save-dev eslint-config-airbnb-base eslint@^3.0.1 eslint-plugin-import@^1.10.3
+  npm install --save-dev eslint-config-airbnb-base eslint@^#.#.# eslint-plugin-import@^#.#.#
   ```
 
 2. Add `"extends": "airbnb-base/legacy"` to your .eslintrc
@@ -97,3 +101,12 @@ Consider adding test cases if you're making complicated rules changes, like anyt
 You can run tests with `npm test`.
 
 You can make sure this module lints with itself using `npm run lint`.
+
+[package-url]: https://npmjs.org/package/eslint-config-airbnb-base
+[npm-version-svg]: https://versionbadg.es/airbnb/javascript.svg
+[license-image]: https://img.shields.io/npm/l/eslint-config-airbnb-base.svg
+[license-url]: LICENSE.md
+[downloads-image]: https://img.shields.io/npm/dm/eslint-config-airbnb-base.svg
+[downloads-url]: https://npm-stat.com/charts.html?package=eslint-config-airbnb-base
+[actions-image]: https://img.shields.io/endpoint?url=https://github-actions-badge-u3jn4tfpocch.runkit.sh/airbnb/javascript
+[actions-url]: https://github.com/airbnb/javascript/actions

packages/eslint-config-airbnb-base/package.json

@@ -1,14 +1,29 @@
 {
   "name": "eslint-config-airbnb-base",
-  "version": "14.2.1",
+  "version": "15.0.0",
   "description": "Airbnb's base JS ESLint config, following our styleguide",
   "main": "index.js",
+  "exports": {
+    ".": "./index.js",
+    "./legacy": "./legacy.js",
+    "./whitespace": "./whitespace.js",
+    "./rules/best-practices": "./rules/best-practices.js",
+    "./rules/es6": "./rules/es6.js",
+    "./rules/node": "./rules/node.js",
+    "./rules/style": "./rules/style.js",
+    "./rules/errors": "./rules/errors.js",
+    "./rules/imports": "./rules/imports.js",
+    "./rules/strict": "./rules/strict.js",
+    "./rules/variables": "./rules/variables.js",
+    "./package.json": "./package.json"
+  },
   "scripts": {
-    "prelint": "eclint check * rules/* test/*",
+    "prelint": "eclint check $(git ls-files | xargs find 2> /dev/null | grep -vE 'node_modules|\\.git')",
     "lint": "eslint --report-unused-disable-directives .",
     "pretests-only": "node ./test/requires",
     "tests-only": "babel-tape-runner ./test/test-*.js",
-    "prepublish": "(in-install || eslint-find-rules --unused) && (not-in-publish || npm test) && safe-publish-latest",
+    "prepublishOnly": "eslint-find-rules --unused && npm test && safe-publish-latest",
+    "prepublish": "not-in-publish || npm run prepublishOnly",
     "pretest": "npm run --silent lint",
     "test": "npm run --silent tests-only",
     "pretravis": ":",
@@ -53,28 +68,25 @@
   },
   "homepage": "https://github.com/airbnb/javascript",
   "devDependencies": {
-    "@babel/runtime": "^7.15.4",
+    "@babel/runtime": "^7.25.6",
     "babel-preset-airbnb": "^4.5.0",
     "babel-tape-runner": "^3.0.0",
     "eclint": "^2.8.1",
-    "eslint": "^5.16.0 || ^6.8.0 || ^7.2.0",
-    "eslint-find-rules": "^3.6.1",
-    "eslint-plugin-import": "^2.24.2",
+    "eslint": "^7.32.0 || ^8.2.0",
+    "eslint-find-rules": "^4.1.0",
+    "eslint-plugin-import": "^2.30.0",
     "in-publish": "^2.0.1",
-    "safe-publish-latest": "^1.1.4",
-    "tape": "^5.3.1"
+    "safe-publish-latest": "^2.0.0",
+    "tape": "^5.9.0"
   },
   "peerDependencies": {
-    "eslint": "^5.16.0 || ^6.8.0 || ^7.2.0",
-    "eslint-plugin-import": "^2.24.2"
+    "eslint": "^7.32.0 || ^8.2.0",
+    "eslint-plugin-import": "^2.30.0"
   },
   "engines": {
-    "node": ">= 6"
+    "node": "^10.12.0 || >=12.0.0"
   },
   "dependencies": {
-    "confusing-browser-globals": "^1.0.10",
-    "object.assign": "^4.1.2",
-    "object.entries": "^1.1.4",
-    "semver": "^6.3.0"
+    "confusing-browser-globals": "^1.0.11"
   }
 }

packages/eslint-config-airbnb-base/rules/best-practices.js

@@ -36,12 +36,10 @@ module.exports = {
 
     // Enforce default clauses in switch statements to be last
     // https://eslint.org/docs/rules/default-case-last
-    // TODO: enable, semver-minor, when eslint v7 is required (which is a major)
-    'default-case-last': 'off',
+    'default-case-last': 'error',
 
     // https://eslint.org/docs/rules/default-param-last
-    // TODO: enable, semver-minor, when eslint v6.4 is required (which is a major)
-    'default-param-last': 'off',
+    'default-param-last': 'error',
 
     // encourages use of dot notation whenever possible
     // https://eslint.org/docs/rules/dot-notation
@@ -57,8 +55,7 @@ module.exports = {
 
     // Require grouped accessor pairs in object literals and classes
     // https://eslint.org/docs/rules/grouped-accessor-pairs
-    // TODO: enable in next major, altho the guide forbids getters/setters anyways
-    'grouped-accessor-pairs': 'off',
+    'grouped-accessor-pairs': 'error',
 
     // make sure for-in loops have an if statement
     // https://eslint.org/docs/rules/guard-for-in
@@ -70,6 +67,7 @@ module.exports = {
 
     // disallow the use of alert, confirm, and prompt
     // https://eslint.org/docs/rules/no-alert
+    // TODO: enable, semver-major
     'no-alert': 'warn',
 
     // disallow use of arguments.caller or arguments.callee
@@ -82,8 +80,7 @@ module.exports = {
 
     // Disallow returning value in constructor
     // https://eslint.org/docs/rules/no-constructor-return
-    // TODO: enable, semver-major
-    'no-constructor-return': 'off',
+    'no-constructor-return': 'error',
 
     // disallow division operators explicitly at beginning of regular expression
     // https://eslint.org/docs/rules/no-div-regex
@@ -107,6 +104,11 @@ module.exports = {
     // https://eslint.org/docs/rules/no-empty-pattern
     'no-empty-pattern': 'error',
 
+    // Disallow empty static blocks
+    // https://eslint.org/docs/latest/rules/no-empty-static-block
+    // TODO: semver-major, enable
+    'no-empty-static-block': 'off',
+
     // disallow comparisons to null without a type-checking operator
     // https://eslint.org/docs/rules/no-eq-null
     'no-eq-null': 'off',
@@ -213,8 +215,12 @@ module.exports = {
 
     // Disallow \8 and \9 escape sequences in string literals
     // https://eslint.org/docs/rules/no-nonoctal-decimal-escape
-    // todo: semver-major: enable when v7.14 is required
-    'no-nonoctal-decimal-escape': 'off',
+    'no-nonoctal-decimal-escape': 'error',
+
+    // Disallow calls to the Object constructor without an argument
+    // https://eslint.org/docs/latest/rules/no-object-constructor
+    // TODO: enable, semver-major
+    'no-object-constructor': 'off',
 
     // disallow use of (old style) octal literals
     // https://eslint.org/docs/rules/no-octal
@@ -381,9 +387,15 @@ module.exports = {
     // https://eslint.org/docs/rules/prefer-named-capture-group
     'prefer-named-capture-group': 'off',
 
+    // Prefer Object.hasOwn() over Object.prototype.hasOwnProperty.call()
+    // https://eslint.org/docs/rules/prefer-object-has-own
+    // TODO: semver-major: enable thus rule, once eslint v8.5.0 is required
+    'prefer-object-has-own': 'off',
+
     // https://eslint.org/docs/rules/prefer-regex-literals
-    // TODO; enable, semver-minor, once eslint v6.4 is required (which is a major)
-    'prefer-regex-literals': 'off',
+    'prefer-regex-literals': ['error', {
+      disallowRedundantWrapping: true,
+    }],
 
     // require use of the second argument for parseInt()
     // https://eslint.org/docs/rules/radix