Skip to content

Webpage #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 2, 2017
Merged

Webpage #58

merged 12 commits into from
Dec 2, 2017

Conversation

stereobooster
Copy link
Collaborator

@stereobooster stereobooster commented May 28, 2017

@MicheleBertoli
Copy link
Owner

Thanks @stereobooster for your PR.
@rofrischmann was working on a web page for the repo a while ago but we never had time to finish it.

@will-stone
Copy link

This is great. May I suggest using Bootstrap for instant CSS boost to the table? Also a filtering mechanism would be good. For example, I only want to see those that support X

@stereobooster
Copy link
Collaborator Author

stereobooster commented Nov 16, 2017

@will-stone yep you right bootstrap is better.

Got again back to css-in-js dilemma, so need this table as decision tool. WDYT?

@stereobooster stereobooster force-pushed the webpage branch 2 times, most recently from e272c2e to 92ec2f1 Compare November 16, 2017 18:34
@stereobooster stereobooster reopened this Nov 16, 2017
@stereobooster
Copy link
Collaborator Author

Ouch I confused branches

@stereobooster
Copy link
Collaborator Author

stereobooster commented Nov 16, 2017

Ratio:

  • it is easier to work with JSON, rather than markdown table. If you want I can generate markdown table from JSON file
  • JSON file can have more columns than markdown table
  • web page can have advanced feature over readme in github, like filter based on features. See https://www.javascriptstuff.com/react-starter-projects/

Current version super simple. But if we want something more advanced we can use https://reactabular.js.org/#/ or https://react-table.js.org/#/story/simple-table

@@ -0,0 +1,25 @@
import React from "react";

const Filter = options => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename options to props.

@MicheleBertoli
Copy link
Owner

Thank you very much @stereobooster, this looks pretty cool.
I like that you used create-react-app, and the code is simple and effective.

I agree it would make sense to have a single source of truth, and it would be great to generate the table from the same JSON file.
Also, as you said, the JSON file could have more columns (which is one of the most requested features for the repo).

I would love to have @rofrischmann's opinion on this.

@stereobooster
Copy link
Collaborator Author

I fixed your comment. Anything else you want me to do in this PR?

@robinweser
Copy link
Collaborator

Is the above example the newest version? I really like how simple it is! Would love to add more details later of course, but for now it's fine.
Just one thing: Can we maybe have a fixed width for the package column? It "jumps" around as I filter, which makes it hard to compare results visually.

@stereobooster
Copy link
Collaborator Author

Yes above generated from latest readme. There is a script which converts markdown to json

@stereobooster
Copy link
Collaborator Author

Made first two columns fixed width

@stereobooster
Copy link
Collaborator Author

Started small vocabulary https://github.com/stereobooster/css-in-js-systematic-approach, want to put definitions for all collumns (aka features) there. Comments are welcome

@MicheleBertoli MicheleBertoli merged commit 5c47c35 into MicheleBertoli:webpage Dec 2, 2017
@MicheleBertoli
Copy link
Owner

You are awesome @stereobooster, thank you very much!
http://michelebertoli.github.io/css-in-js/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants