-
Notifications
You must be signed in to change notification settings - Fork 285
Webpage #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpage #58
Conversation
Thanks @stereobooster for your PR. |
This is great. May I suggest using Bootstrap for instant CSS boost to the table? Also a filtering mechanism would be good. For example, I only want to see those that support X |
@will-stone yep you right bootstrap is better. Got again back to css-in-js dilemma, so need this table as decision tool. WDYT? |
e272c2e
to
92ec2f1
Compare
Ouch I confused branches |
92ec2f1
to
181bcd1
Compare
Ratio:
Current version super simple. But if we want something more advanced we can use https://reactabular.js.org/#/ or https://react-table.js.org/#/story/simple-table |
src/components/Filter.js
Outdated
@@ -0,0 +1,25 @@ | |||
import React from "react"; | |||
|
|||
const Filter = options => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rename options
to props
.
Thank you very much @stereobooster, this looks pretty cool. I agree it would make sense to have a single source of truth, and it would be great to generate the table from the same JSON file. I would love to have @rofrischmann's opinion on this. |
I fixed your comment. Anything else you want me to do in this PR? |
Is the above example the newest version? I really like how simple it is! Would love to add more details later of course, but for now it's fine. |
Yes above generated from latest readme. There is a script which converts markdown to json |
Made first two columns fixed width |
Started small vocabulary https://github.com/stereobooster/css-in-js-systematic-approach, want to put definitions for all collumns (aka features) there. Comments are welcome |
You are awesome @stereobooster, thank you very much! |
Demo https://stereobooster.github.io/css-in-js/
We can get domain from https://js.org/