Skip to content

Update image used #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Update image used #190

merged 1 commit into from
Apr 23, 2025

Conversation

mbiver
Copy link
Contributor

@mbiver mbiver commented Mar 25, 2025

Platform image 20h1-ent is no longer present, so will want to update or it will fail. Also, as we now default to generation 2, will want to make sure the image is g2 or it will also fail. win10-21h2-ent-g2 works for now.

Platform image 20h1-ent is no longer present, so will want to update or it will fail.  Also, as we now default to generation 2, will want to make sure the image is g2 or it will also fail.  win10-21h2-ent-g2 works for now.
Copy link
Contributor

@mbiver : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit bfd9ed9:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/windows/image-builder-virtual-desktop.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@mbiver
Copy link
Contributor Author

mbiver commented Mar 25, 2025

If we update the image to Gen 2, since that the new default, we'll also need to update the VM size, as the current size "Standard_D2_v2" doesn't support Gen 2 VM's. Below should fix the template.

((Get-Content -path $templateFilePath -Raw) -replace 'Standard_D2_v2','Standard_D2_v4') | Set-Content -Path $templateFilePath

@mbiver
Copy link
Contributor Author

mbiver commented Mar 25, 2025

Will also need to update this section then:

VM size: For Windows, use Standard_D2_v2 or greater. The default size is Standard_D1_v2, which isn't suitable for Windows.

@v-dirichards
Copy link
Contributor

@kof-f

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Mar 25, 2025
Copy link

github-actions bot commented Apr 9, 2025

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Apr 9, 2025
Copy link
Contributor

@mbiver : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@v-dirichards
Copy link
Contributor

@kof-f - Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Apr 9, 2025
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Apr 23, 2025
@v-dirichards
Copy link
Contributor

@kof-f

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@kof-f
Copy link
Contributor

kof-f commented Apr 23, 2025

#sign-off

@v-dirichards v-dirichards merged commit d086d34 into MicrosoftDocs:main Apr 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants