Skip to content

Update prometheus-kafka-integration.md #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

colinmixonn
Copy link

AKS team recently developed a guide to deploy Kafka on AKS including infrastructure and Kafka deployment. I think it would be good to integrate the links for user discoverability.

AKS team recently developed a guide to deploy Kafka on AKS including infrastructure and Kafka deployment. I think it would be good to integrate the links for user discoverability.
Copy link
Contributor

@colinmixonn : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit a4dfeb5:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/azure-monitor/containers/prometheus-kafka-integration.md ⚠️Warning Details

articles/azure-monitor/containers/prometheus-kafka-integration.md

  • Line 14, Column 66: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/aks/kafka-infrastructure?pivots=azure-cli' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 14, Column 66: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/aks/kafka-infrastructure?pivots=azure-cli' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

@colinmixonn : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@v-dirichards
Copy link
Contributor

@bwren

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Apr 8, 2025
Copy link
Contributor

Learn Build status updates of commit 7c907af:

💡 Validation status: suggestions

File Status Preview URL Details
articles/azure-monitor/containers/prometheus-kafka-integration.md 💡Suggestion Details

articles/azure-monitor/containers/prometheus-kafka-integration.md

  • Line 14, Column 66: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/aks/kafka-infrastructure?pivots=azure-cli' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@colinmixonn
Copy link
Author

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @bwren

@v-dirichards
Copy link
Contributor

Hi @colinmixonn - Thanks for your review. In the public repo, pull requests should be signed off by the author, another member of the content team, or a PM.


@bwren Could you take a look? Thanks!

@colinmixonn
Copy link
Author

I see thank you Diana!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants