-
Notifications
You must be signed in to change notification settings - Fork 104
Update prometheus-kafka-integration.md #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
AKS team recently developed a guide to deploy Kafka on AKS including infrastructure and Kafka deployment. I think it would be good to integrate the links for user discoverability.
@colinmixonn : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit a4dfeb5:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/azure-monitor/containers/prometheus-kafka-integration.md | Details |
articles/azure-monitor/containers/prometheus-kafka-integration.md
- Line 14, Column 66: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/azure/aks/kafka-infrastructure?pivots=azure-cli' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 14, Column 66: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/azure/aks/kafka-infrastructure?pivots=azure-cli' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
@colinmixonn : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
articles/azure-monitor/containers/prometheus-kafka-integration.md
Outdated
Show resolved
Hide resolved
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Learn Build status updates of commit 7c907af: 💡 Validation status: suggestions
articles/azure-monitor/containers/prometheus-kafka-integration.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
#sign-off |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @bwren |
Hi @colinmixonn - Thanks for your review. In the public repo, pull requests should be signed off by the author, another member of the content team, or a PM. @bwren Could you take a look? Thanks! |
I see thank you Diana! |
AKS team recently developed a guide to deploy Kafka on AKS including infrastructure and Kafka deployment. I think it would be good to integrate the links for user discoverability.