Skip to content

New article on Azure Maps services tenant settings #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stevemunk
Copy link

Thank you for contributing to Microsoft Fabric documentation

Fill out these items before submitting your pull request:

If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.

Who is your primary Skilling team contact? @mention them individually tag them and let them review the PR before signing off.

For internal Microsoft contributors, check off these quality control items as you go

  • 1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.

  • 2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).

  • 3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.

  • 4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.

  • 5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the Pull Request. If you need to cancel that sign-off, type #hold-off instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.

Merge and publish

  • After you #sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.
  • The review team will use the comments section in the PR to provide feedback if changes are needed. Address any blocking issues and sign off again to request another review.
  • Once all feedback is resolved, you can #sign-off again. The PR Review team reviews and merges the pull request into the specified branch (usually the main branch or a release- branch).
  • From the main branch, the change is merged into the live branch several times a day to publish it to the public learn.microsoft.com site.

Copy link
Contributor

@stevemunk : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. @sipa

Copy link
Contributor

@stevemunk : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. @sipa

Copy link
Contributor

Learn Build status updates of commit a16181a:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/admin/service-admin-portal-azure-maps-services.md ⚠️Warning Details
docs/admin/media/service-admin-azure-maps/fabric-azure-maps-cross-data-processing-enabled.png ✅Succeeded
docs/admin/media/service-admin-azure-maps/fabric-azure-maps-enabled.jpg ✅Succeeded
docs/admin/toc.yml ✅Succeeded

docs/admin/service-admin-portal-azure-maps-services.md

  • Line 22, Column 118: [Warning: file-not-found - See documentation] Invalid file link: './azure/azure-maps/about-azure-maps'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit c8c56e7:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/admin/service-admin-portal-azure-maps-services.md ⚠️Warning Details
docs/admin/media/service-admin-azure-maps/fabric-azure-maps-cross-data-processing-enabled.png ✅Succeeded
docs/admin/media/service-admin-azure-maps/fabric-azure-maps-enabled.jpg ✅Succeeded
docs/admin/toc.yml ✅Succeeded

docs/admin/service-admin-portal-azure-maps-services.md

  • Line 22, Column 118: [Warning: file-not-found - See documentation] Invalid file link: './azure/azure-maps/about-azure-maps'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit d434c9e:

✅ Validation status: passed

File Status Preview URL Details
docs/admin/media/service-admin-azure-maps/fabric-azure-maps-cross-data-processing-enabled.png ✅Succeeded
docs/admin/media/service-admin-azure-maps/fabric-azure-maps-enabled.jpg ✅Succeeded
docs/admin/service-admin-portal-azure-maps-services.md ✅Succeeded
docs/admin/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.
Image File This PR added or updated an image file(s).

@stevemunk
Copy link
Author

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @sipa

@sipa
Copy link

sipa commented Mar 27, 2025

Why am I the assigned author here? I know nothing about this.

@dubiety
Copy link

dubiety commented Mar 27, 2025

Hi @sipa , sorry that is an internal alias, it's automatically triggered and tagged by GitHub alias, please ignore. Thanks for your understanding!

Copy link
Contributor

@sinnypan sinnypan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stevemunk. Please hold this PR until the new features go live, thank you so much.

@v-dirichards
Copy link
Contributor

Due to the upcoming FabCon conference, all merging and publishing is on hold until the morning of March 31.

This PR is ready for merge on March 31.

#label: "event-triaged-to-10AM"
#label: "missed-content-complete"
#label: "ready-to-merge"

@v-dirichards
Copy link
Contributor

LGTM, thanks @stevemunk. Please hold this PR until the new features go live, thank you so much.

@sinnypan The merging freeze has lifted. Are we ok to merge it?

@v-dirichards
Copy link
Contributor

@sinnypan This content requires automated and human checks available only in the private repository. Please close this PR (#please-close) and move the commits to the private repository. If you need help moving the commits, contact the publicprs alias.

Copy link

This pull request has been inactive for 14 days, and an inactive label has been added. If you are finished with your changes don't forget to sign off in the comments of the pull request to request a review and merge. If you want to continue working without merging, simply add a comment about why you want to keep this PR open. If this PR is inactive with no comments for 14 more days, it will be closed automatically.
Thank you!
Microsoft Fabric Docs team
PS: Mention us in the comments @MicrosoftDocs/fabric-docs-team if you need assistance.

@v-regandowner
Copy link
Contributor

@sinnypan @stevemunk - This content requires automated and human checks available only in the private repository. Please close this PR (#please-close) and move the commits to the private repository. If you need help moving the commits, contact the publicprs alias.

@MicrosoftDocs/public-repo-pr-review-team
#hold-off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants