-
Notifications
You must be signed in to change notification settings - Fork 256
Connect parameter #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect parameter #321
Conversation
This PR allows to declare a lazy connection with `MONGODB_CONNECT = False` because right now only the `MONGODB_SETTINGS` dict support this parameter
Please complete this merge request, the Travis errors seem to be total BS, i.e. pip and PyPy3 related |
Any news on this one ? |
@touilleMan @rozza @wojcikstefan |
Looks good to me. Care to add a test in https://github.com/MongoEngine/flask-mongoengine/blob/master/tests/test_connection.py#L169? Indeed, the CI failure is unrelated (I relaunched the tests for latest commit in master in got the same errors). I'm not involved in flask-mongoengine anymore as I'm using @touilleMan's umongo. @rozza isn't involed anymore either AFAIK. @noirbizarre, I can give you write access if you want to help maintaining flask-mongoengine. @MongoEngine/flask-mongoengine, any objection? |
@lafrech that's fine for me ;-) (you should give @noirbizarre write right to the whole mongoengine organisation if you can) |
Thanks ! I'm using mongoengine on only one project now, but it's an important project. I also switched on umongo on my other projets 😉 Glad to see that's the same team. |
@noirbizarre, I can't invite you to the organization. I invited you to be a collaborator on both Mongoengine and flask-mongoengine. No pressure to do any work. |
@noirbizarre Happy to hear you find umongo useful ;-) |
Yes, great ! I'll be glad to help on umongo too (I'll have some patches to submit and I'm working on a factory module for umongo aka. a factoryboy-like but async) |
@noirbizarre welcome aboard 🎉 |
This PR allows to use
MONGODB_CONNECT
parameter and document both the existingMONGO_SETTINGS['connect']
and the newMONGODB_CONNECT
parameters.I had to read #255 to discover this possibility which isn't documented and this solve a common issue.
Context: this feature seems to appear in #280 but there was issues and PRs before. ex: #255, #266, #126