Skip to content

Wrong type for Project.id #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
azatoth opened this issue Apr 4, 2025 · 0 comments · Fixed by #372 or #373
Closed

Wrong type for Project.id #371

azatoth opened this issue Apr 4, 2025 · 0 comments · Fixed by #372 or #373
Assignees
@MrRefactoring
Labels
enhancement Denotes a suggestion or request aimed at improving or adding new features to the project.
Milestone
v4.1.2

Comments

@azatoth
Copy link

azatoth commented Apr 4, 2025

Project.id is defined as a string, but methods like ProjectVersions.createVersion has a Version.projectId with type number.
@MrRefactoring MrRefactoring self-assigned this Apr 4, 2025
@MrRefactoring MrRefactoring added the enhancement Denotes a suggestion or request aimed at improving or adding new features to the project. label Apr 4, 2025
@MrRefactoring MrRefactoring added this to the v4.1.1 milestone Apr 4, 2025
MrRefactoring added a commit that referenced this issue Apr 4, 2025
@MrRefactoring
v4.1.1
cd8091d 
- **Fix:** Fixed compilation issues for projects using the `Plans.updatePlan` method in `Version3Client`. Thanks to Jakub Gladykowski ([gladykov](https://github.com/gladykov)) for reporting this issue ([#370](#370)).
- **Improvement:** Added `string` type support for the `projectId` property in the `Version` model for `Version3Client`. Thanks to Carl Fürstenberg ([azatoth](https://github.com/azatoth)) for suggesting this improvement ([#371](#371)).
@MrRefactoring MrRefactoring mentioned this issue Apr 4, 2025
Merged
@MrRefactoring MrRefactoring linked a pull request Apr 4, 2025 that will close this issue
v4.1.1 #372
Merged
MrRefactoring added a commit that referenced this issue Apr 5, 2025
@MrRefactoring
v4.1.1 (#372)
ee5a12d 
* v4.1.1

- **Fix:** Fixed compilation issues for projects using the `Plans.updatePlan` method in `Version3Client`. Thanks to Jakub Gladykowski ([gladykov](https://github.com/gladykov)) for reporting this issue ([#370](#370)).
- **Improvement:** Added `string` type support for the `projectId` property in the `Version` model for `Version3Client`. Thanks to Carl Fürstenberg ([azatoth](https://github.com/azatoth)) for suggesting this improvement ([#371](#371)).

* projectId marked as optional
MrRefactoring added a commit that referenced this issue Apr 5, 2025
@MrRefactoring
v4.1.2
540d73b 
- **Fix:** Fixed compilation issues for projects using the `Plans.updatePlan` method in `Version3Client`. Thanks to Jakub Gladykowski ([gladykov](https://github.com/gladykov)) for reporting this issue ([#370](#370)).
- **Improvement:** Added `string` type support for the `projectId` property in the `Version` model for `Version3Client`. Thanks to Carl Fürstenberg ([azatoth](https://github.com/azatoth)) for suggesting this improvement ([#371](#371)).
@MrRefactoring MrRefactoring linked a pull request Apr 5, 2025 that will close this issue
v4.1.2 #373
Merged
MrRefactoring added a commit that referenced this issue Apr 5, 2025
@MrRefactoring
v4.1.2 (#373)
8637655 
- **Fix:** Fixed compilation issues for projects using the `Plans.updatePlan` method in `Version3Client`. Thanks to Jakub Gladykowski ([gladykov](https://github.com/gladykov)) for reporting this issue ([#370](#370)).
- **Improvement:** Added `string` type support for the `projectId` property in the `Version` model for `Version3Client`. Thanks to Carl Fürstenberg ([azatoth](https://github.com/azatoth)) for suggesting this improvement ([#371](#371)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrRefactoring MrRefactoring

Labels
enhancement Denotes a suggestion or request aimed at improving or adding new features to the project.
Projects
None yet
Milestone
v4.1.2
Development

Successfully merging a pull request may close this issue.

v4.1.1 MrRefactoring/jira.js
v4.1.2 MrRefactoring/jira.js
2 participants
@azatoth @MrRefactoring