Skip to content

Set Content-Type in issueBulkOperations.submitBulkTransition to work around api issue #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Cellule
Copy link
Contributor

@Cellule Cellule commented Apr 12, 2025

Fixes #374

@MrRefactoring MrRefactoring self-requested a review April 12, 2025 20:58
@MrRefactoring
Copy link
Owner

It would be wonderful if you could write an integration test case

@Cellule
Copy link
Contributor Author

Cellule commented Apr 14, 2025

I didn't see any tests for other bulk operations so I wrote a new test file
I didn't actually run the integration test, I'm not really setup for it right this moment and I'm not sure I want to run this against my company jira instance
If there are problems I could look at setting up locally to run integration tests

Edit: I created a personal jira instance to run the tests and everything looks good. I've also confirmed that the test fails if I comment out the Content-Type fix

I also noticed the typescript config wasn't picking up the tests files causing a whole bunch of errors in IDE so I fixed that
Then I noticed the tests files weren't compiled in CI so I added that and fixed the build
Let me know what you think

@MrRefactoring MrRefactoring added this to the v4.1.3 milestone Apr 14, 2025
@MrRefactoring MrRefactoring changed the base branch from master to release/v4.1.3 April 14, 2025 19:42
@MrRefactoring
Copy link
Owner

I’ll merge your changes to test more thoroughly and may make some adjustments

@MrRefactoring MrRefactoring merged commit a05fdf1 into MrRefactoring:release/v4.1.3 Apr 14, 2025
@MrRefactoring MrRefactoring mentioned this pull request Apr 14, 2025
@MrRefactoring
Copy link
Owner

I took a closer look, and it’s excellent work—you’re a total brainiac to catch a problem like this!

MrRefactoring added a commit that referenced this pull request Apr 14, 2025
* Set Content-Type in issueBulkOperations.submitBulkTransition to work around api issue (#375)

* Set Content-Type in issueBulkOperations.submitBulkTransition to work around api issue.
Fixes #374

* Fix test typescript build

* Add getAvailableTransitions tests

* v4.1.3

* Changelog updated

---------

Co-authored-by: Michael "Mike" Ferris <[email protected]>
@Cellule
Copy link
Contributor Author

Cellule commented Apr 14, 2025

I took a closer look, and it’s excellent work—you’re a total brainiac to catch a problem like this!

Hahaha thanks, I was pretty deep down the rabbit hole and I'm trying to crawl out of it slowly XD
Can't wait to use it in my project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

415 on issueBulkOperations.getAvailableTransitions /rest/api/3/bulk/issues/transition
2 participants