Skip to content

OAuth1 support #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2020
Merged

OAuth1 support #89

merged 1 commit into from
Dec 28, 2020

Conversation

jayree
Copy link
Contributor

@jayree jayree commented Dec 15, 2020

@MrRefactoring I think this is what @VizinteanuGeorge was looking for in #86. I recently had the same requirement.

@MrRefactoring
Copy link
Owner

Hey @jayree! Thank you for help!

It looks good. I have a couple of questions.

  1. Have you tested these changes or can you find someone who can test this and tell me if this solution works correctly?

  2. I would prefer to remove the dependency on qs, it's quite heavy, I don't think you would have any trouble writing your implementation

MrRefactoring
MrRefactoring reviewed Dec 15, 2020
View reviewed changes
@MrRefactoring MrRefactoring self-assigned this Dec 15, 2020
@MrRefactoring
Copy link
Owner

And please describe how to use it in the README. Thank you very much

@jayree
Copy link
Contributor Author

jayree commented Dec 20, 2020

Hey @jayree! Thank you for help!

It looks good. I have a couple of questions.

  1. Have you tested these changes or can you find someone who can test this and tell me if this solution works correctly?

yes it's tested already. I'll update the README.

jayree
jayree commented Dec 22, 2020
View reviewed changes
jayree
jayree commented Dec 27, 2020
View reviewed changes
MrRefactoring
MrRefactoring reviewed Dec 27, 2020
View reviewed changes
@MrRefactoring
Copy link
Owner

Thank you @jayree! LGTM. I finally check this PR tomorrow and if all good than will been merged

MrRefactoring
MrRefactoring approved these changes Dec 28, 2020
View reviewed changes
Copy link
Owner

@MrRefactoring MrRefactoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I will add this to the release soon

@MrRefactoring MrRefactoring merged commit 5601540 into MrRefactoring:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrRefactoring MrRefactoring MrRefactoring approved these changes

Assignees

@MrRefactoring MrRefactoring

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayree @MrRefactoring