Potential revision to optimise convert_byte_size #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been optimising a lot of Python code recently and offer this as a potential alternative to convert_byte_size(). Removing the nested if.. elif... statements and making it easier to add additional si prefixes in the future if desired.
32 tasks
|
This looks like a great improvement! @bhass-neon It looks like we're currently duplicating the convert_byte_size() function in aop_download.py and metadata_helpers.py. Can you take a look and see if we can implement the improved version just in metadata_helpers.py, so the function can be used in both aop_download and tabular_download from the same source? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been optimising a lot of Python code recently and offer this as a potential alternative to convert_byte_size(). Removing the nested if.. elif... statements and making it easier to add additional si prefixes in the future if desired.