Skip to content

Fix/colang 2/flow continuation prompt #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix/colang 2/flow continuation prompt #775

merged 2 commits into from
Oct 2, 2024

Conversation

schuellc-nvidia
Copy link
Collaborator

  • Fixes the assigned prompt role.
  • Also increases a unit test threshold since it sporadically still fails.

@schuellc-nvidia schuellc-nvidia self-assigned this Sep 25, 2024
sklinglernv
sklinglernv reviewed Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@sklinglernv sklinglernv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, not sure if other template needs to be updated as well?

@sklinglernv sklinglernv self-requested a review September 30, 2024 11:58
sklinglernv
sklinglernv approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@sklinglernv sklinglernv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side.

@cparisien cparisien merged commit dc0fbe0 into develop Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklinglernv sklinglernv sklinglernv approved these changes

@drazvan drazvan Awaiting requested review from drazvan

Assignees

@schuellc-nvidia schuellc-nvidia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schuellc-nvidia @sklinglernv @cparisien