feat: add etcd dependency and interface #3597
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/Dockerfile.multi
Outdated
| @@ -57,6 +57,10 @@ RUN bash ./install_polygraphy.sh && rm install_polygraphy.sh | |||
| COPY docker/common/install_mpi4py.sh install_mpi4py.sh | |||
| RUN bash ./install_mpi4py.sh && rm install_mpi4py.sh | |||
|
|
|||
| # Install etcd | |||
| COPY docker/common/install_etcd.sh install_etcd.sh | |||
There was a problem hiding this comment.
Could you please contact @ZhanruiSunCh to update the Docker image?
Shunkangz
force-pushed
the
add_metadata_service_support
branch
3 times, most recently
from
fde236c to
ca4d1d6
Compare
kaiyux
reviewed
Apr 17, 2025
There was a problem hiding this comment.
Sorry I should've missed some context - why is this file needed and where is it going to be used? Should we wait until there are changes that actually use those data structures?
There was a problem hiding this comment.
After discussion with @Shixiaowei02 , we plan to split the support of dynamic scaling into a few small PRs. In this PR, we want to align the interface of etcd first and there will be another MR depends on this. I will submit it soon.
added 2 commits
April 20, 2025 23:36
Signed-off-by: Shunkang <[email protected]>
Signed-off-by: Shunkang <[email protected]>
Shunkangz
force-pushed
the
add_metadata_service_support
branch
from
ca4d1d6 to
5013d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The etcd will be added in dockerfile in MR #3616