Skip to content

Remove dummy forward path #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 18, 2025
Merged

Remove dummy forward path #3669

merged 7 commits into from
Apr 18, 2025

Conversation

HuiGao-NV
Copy link
Collaborator

Since real forward path is ran to estimate memory consumption now, dummy_forward can be removed now.

Signed-off-by: HuiGao

@HuiGao-NV
Copy link
Collaborator Author

/bot run

@HuiGao-NV HuiGao-NV self-assigned this Apr 18, 2025
@HuiGao-NV HuiGao-NV requested a review from yuxianq April 18, 2025 00:31
@tensorrt-cicd
Copy link
Collaborator

PR_Github #2693 [ run ] triggered by Bot

@HuiGao-NV HuiGao-NV force-pushed the remove_dummy_forward branch from 0208dae to 9750b6f Compare April 18, 2025 03:17
@tensorrt-cicd
Copy link
Collaborator

PR_Github #2693 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #1923 completed with status: 'FAILURE'

@HuiGao-NV
Copy link
Collaborator Author

/bot run --stage-list="L40S-PyTorch-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2713 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2713 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #1934 (Partly Tested) completed with status: 'SUCCESS'

@HuiGao-NV HuiGao-NV force-pushed the remove_dummy_forward branch from 96ddd70 to 6fdb399 Compare April 18, 2025 06:21
@HuiGao-NV
Copy link
Collaborator Author

/bot reuse-pipeline

@HuiGao-NV HuiGao-NV enabled auto-merge (squash) April 18, 2025 06:22
@HuiGao-NV
Remove dummy forward path
920f9a0 
Signed-off-by: HuiGao
Signed-off-by: Hui Gao <[email protected]>
@HuiGao-NV
Remove code accessing is_dummy_attention
d720726 
Signed-off-by: Hui Gao <[email protected]>
@HuiGao-NV
Remove one line from doc
a9877a0 
Signed-off-by: Hui Gao <[email protected]>
@tensorrt-cicd
Copy link
Collaborator

PR_Github #2731 [ reuse-pipeline ] triggered by Bot

@HuiGao-NV HuiGao-NV force-pushed the remove_dummy_forward branch from 6fdb399 to a9877a0 Compare April 18, 2025 06:29
@HuiGao-NV HuiGao-NV disabled auto-merge April 18, 2025 06:29
@HuiGao-NV HuiGao-NV enabled auto-merge (squash) April 18, 2025 06:30
@tensorrt-cicd
Copy link
Collaborator

PR_Github #2731 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #2713 (Partly Tested) for commit 6fdb399

@HuiGao-NV
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2737 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2737 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #2713 (Partly Tested) for commit 7cdf609

@HuiGao-NV
Copy link
Collaborator Author

/bot skip --comment "rebase code"

@HuiGao-NV
Copy link
Collaborator Author

/bot skip --comment "rebase code"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2745 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2748 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2745 [ skip ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2748 [ skip ] completed with state SUCCESS
Skipping testing for commit 69ba0d7

@HuiGao-NV
Copy link
Collaborator Author

/bot skip --comment "rebase code"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2752 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #2752 [ skip ] completed with state SUCCESS
Skipping testing for commit e6179b0

@HuiGao-NV HuiGao-NV merged commit d3608d6 into NVIDIA:main Apr 18, 2025
3 checks passed
@HuiGao-NV HuiGao-NV deleted the remove_dummy_forward branch April 18, 2025 08:35
wu1du2 pushed a commit to wu1du2/TensorRT-LLM that referenced this pull request May 11, 2025
@HuiGao-NV
Remove dummy forward path (NVIDIA#3669)
b948828 
Remove dummy forward path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxianq yuxianq yuxianq approved these changes

Assignees

@HuiGao-NV HuiGao-NV

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuiGao-NV @tensorrt-cicd @yuxianq