Skip to content

[feat]: Allow for a settable end-of-sequence/padding token in max throughput benchmark. #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 1, 2025

Conversation

FrankD412
Copy link
Collaborator

This PR adds the ability to specify the EOS + PAD identifiers when running the throughput benchmark via trtllm-bench. The throughput subcommand is currently our primary way to interact with the PyTorch backend so all related work is going through this subcommand and there are cases where we need to be able to ignore/not ignore the EOS.

@FrankD412 FrankD412 requested review from kaiyux and schetlur-nv April 22, 2025 20:30
@FrankD412 FrankD412 force-pushed the trtllm-bench/eos_option branch from 39d88a8 to 91c7512 Compare April 28, 2025 16:43
@FrankD412 FrankD412 self-assigned this Apr 28, 2025
@FrankD412
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3636 [ run ] triggered by Bot

@FrankD412 FrankD412 requested a review from Superjomn April 28, 2025 18:47
@FrankD412 FrankD412 changed the title Trtllm bench/eos option Allow for a settable end-of-sequence/padding token in max throughput benchmark. Apr 28, 2025
@FrankD412 FrankD412 changed the title Allow for a settable end-of-sequence/padding token in max throughput benchmark. feat: Allow for a settable end-of-sequence/padding token in max throughput benchmark. Apr 28, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #3636 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #2571 completed with status: 'SUCCESS'

@FrankD412 FrankD412 requested a review from nvpohanh April 29, 2025 03:15
@FrankD412 FrankD412 changed the title feat: Allow for a settable end-of-sequence/padding token in max throughput benchmark. [feat]: Allow for a settable end-of-sequence/padding token in max throughput benchmark. Apr 29, 2025
@nvpohanh nvpohanh enabled auto-merge (squash) April 29, 2025 06:04
@FrankD412 FrankD412 requested a review from a team as a code owner April 29, 2025 15:16
@FrankD412
Copy link
Collaborator Author

/bot --reuse-pipeline

Copy link

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@nvpohanh
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3776 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3776 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #2673 completed with status: 'FAILURE'

@FrankD412
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3899 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #3899 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #2765 completed with status: 'SUCCESS'

@nvpohanh nvpohanh merged commit 1e317c9 into NVIDIA:main May 1, 2025
3 checks passed
nvpohanh pushed a commit to nvpohanh/TensorRT-LLM that referenced this pull request May 5, 2025
…oughput benchmark. (NVIDIA#3776)

* Move world options to a different group for clarity.

Signed-off-by: Frank Di Natale <[email protected]>

* Add eos_id option.

Signed-off-by: Frank Di Natale <[email protected]>

---------

Signed-off-by: Frank Di Natale <[email protected]>
nvpohanh added a commit that referenced this pull request May 5, 2025
…oughput benchmark. (#3776) (#4054)

* Move world options to a different group for clarity.



* Add eos_id option.



---------

Signed-off-by: Frank Di Natale <[email protected]>
Co-authored-by: Frank <[email protected]>
dsingal0 pushed a commit to dsingal0/TensorRT-LLM that referenced this pull request May 9, 2025
…oughput benchmark. (NVIDIA#3776)

* Move world options to a different group for clarity.

Signed-off-by: Frank Di Natale <[email protected]>

* Add eos_id option.

Signed-off-by: Frank Di Natale <[email protected]>

---------

Signed-off-by: Frank Di Natale <[email protected]>
Signed-off-by: Dhruv Singal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants