-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[feat]: Allow for a settable end-of-sequence/padding token in max throughput benchmark. #3776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Frank Di Natale <[email protected]>
Signed-off-by: Frank Di Natale <[email protected]>
39d88a8
to
91c7512
Compare
/bot run |
PR_Github #3636 [ run ] triggered by Bot |
PR_Github #3636 [ run ] completed with state |
/bot --reuse-pipeline |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand.
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
/bot run |
PR_Github #3776 [ run ] triggered by Bot |
PR_Github #3776 [ run ] completed with state |
/bot run |
PR_Github #3899 [ run ] triggered by Bot |
PR_Github #3899 [ run ] completed with state |
…oughput benchmark. (NVIDIA#3776) * Move world options to a different group for clarity. Signed-off-by: Frank Di Natale <[email protected]> * Add eos_id option. Signed-off-by: Frank Di Natale <[email protected]> --------- Signed-off-by: Frank Di Natale <[email protected]>
…oughput benchmark. (#3776) (#4054) * Move world options to a different group for clarity. * Add eos_id option. --------- Signed-off-by: Frank Di Natale <[email protected]> Co-authored-by: Frank <[email protected]>
…oughput benchmark. (NVIDIA#3776) * Move world options to a different group for clarity. Signed-off-by: Frank Di Natale <[email protected]> * Add eos_id option. Signed-off-by: Frank Di Natale <[email protected]> --------- Signed-off-by: Frank Di Natale <[email protected]> Signed-off-by: Dhruv Singal <[email protected]>
This PR adds the ability to specify the EOS + PAD identifiers when running the throughput benchmark via
trtllm-bench
. Thethroughput
subcommand is currently our primary way to interact with the PyTorch backend so all related work is going through this subcommand and there are cases where we need to be able to ignore/not ignore the EOS.