Fix resolution of libs in LDCache on ARM #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we explicitly check for the architecture of the libraries in the ldcache, we need to also check the architecture flag against the ARM constants. Signed-off-by: Evan Lezar <[email protected]>
arnaldo2792
reviewed
Apr 23, 2025
| // flagArch_ARM_LIBHF is the flag value for 32-bit ARM libs using hard-float. | ||
| flagArch_ARM_LIBHF = 0x0900 | ||
| // flagArch_AARCH64_LIB64 is the flag value for 64-bit ARM libs. | ||
| flagArch_AARCH64_LIB64 = 0x0a00 |
There was a problem hiding this comment.
Yup, this is how I fixed it, should you all carry on all the flags that libnvidia-container supports?
There was a problem hiding this comment.
Yes, we could do that. Although we don't actively test on some of the platforms called out there anymore.
I will audit the list once more.
There was a problem hiding this comment.
@arnaldo2792 I think for the time being I'm not going to update this list and only stick to ARM. If you have experience with other platforms that we should address, please let me know.
elezar
added
the
must-backport
jgehrcke
approved these changes
May 7, 2025
ArangoGutierrez
approved these changes
May 7, 2025
cdesiniotis
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we explicitly check for the architecture of the libraries in the ldcache, we need to also check the architecture flag against the ARM constants.
Fixes #1045