Add rprivate to CDI mount options #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
requested review from
klueska,
jgehrcke,
ArangoGutierrez and
cdesiniotis
elezar
force-pushed
the
add-rprivate-to-mount-options
branch
from
2563d17 to
a4956e6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that mount propagation is set to rprivate for host-to-container mounts by replacing the "bind" option with "rbind" and adding "rprivate".
- Updates test files and production code to use the updated mount options.
- Aligns mount options configuration with Docker’s default behavior to prevent propagation issues.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/platform-support/tegra/csv_test.go | Updated mount options in CSV-related test cases |
| internal/discover/mounts_test.go | Updated mount options in mount tests |
| internal/discover/mounts.go | Modified the production mount configuration |
| internal/discover/mounts-to-container-path_test.go | Updated mount options in container-path test cases |
| internal/discover/mounts-to-container-path.go | Updated mount options in container-path logic |
| internal/discover/ipc_test.go | Updated mount options in IPC mount tests |
| cmd/nvidia-ctk/cdi/generate/generate_test.go | Updated mount options in CDI generation tests |
| cmd/nvidia-ctk-installer/container/toolkit/toolkit_test.go | Updated mount options in installer tests |
ArangoGutierrez
approved these changes
May 6, 2025
This ensures that mount propagation is set to rprivate for mounts from the host into the container. This aligns with the default in docker. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
add-rprivate-to-mount-options
branch
from
a4956e6 to
d0103aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that mount propagation is set to rprivate for mounts from the host into the container. This aligns with the default in docker.
This would also prevent issues such as #697