Skip to content

Commit 3b1f713

Browse files
authored
Merge pull request kubernetes-sigs#11073 from sbueringer/pr-remove-redundant-tests
🌱 Remove redundant self-hosted and clusterctl upgrade tests
2 parents 21ccc77 + 74765f7 commit 3b1f713

File tree

2 files changed

+0
-71
lines changed

2 files changed

+0
-71
lines changed

test/e2e/clusterctl_upgrade_test.go

-58
Original file line numberDiff line numberDiff line change
@@ -218,38 +218,6 @@ var _ = Describe("When testing clusterctl upgrades (v1.0=>current)", func() {
218218
})
219219
})
220220

221-
// Note: This test should be changed during "prepare main branch", it should test n-2 => current.
222-
var _ = Describe("When testing clusterctl upgrades (v1.7=>current)", func() {
223-
// Get v1.7 latest stable release
224-
version := "1.7"
225-
stableRelease, err := GetStableReleaseOfMinor(ctx, version)
226-
Expect(err).ToNot(HaveOccurred(), "Failed to get stable version for minor release : %s", version)
227-
ClusterctlUpgradeSpec(ctx, func() ClusterctlUpgradeSpecInput {
228-
return ClusterctlUpgradeSpecInput{
229-
E2EConfig: e2eConfig,
230-
ClusterctlConfigPath: clusterctlConfigPath,
231-
BootstrapClusterProxy: bootstrapClusterProxy,
232-
ArtifactFolder: artifactFolder,
233-
SkipCleanup: skipCleanup,
234-
InfrastructureProvider: ptr.To("docker"),
235-
InitWithBinary: fmt.Sprintf(clusterctlDownloadURL, stableRelease),
236-
// We have to pin the providers because with `InitWithProvidersContract` the test would
237-
// use the latest version for the contract (which is the next minor for v1beta1).
238-
InitWithCoreProvider: fmt.Sprintf(providerCAPIPrefix, stableRelease),
239-
InitWithBootstrapProviders: []string{fmt.Sprintf(providerKubeadmPrefix, stableRelease)},
240-
InitWithControlPlaneProviders: []string{fmt.Sprintf(providerKubeadmPrefix, stableRelease)},
241-
InitWithInfrastructureProviders: []string{fmt.Sprintf(providerDockerPrefix, stableRelease)},
242-
InitWithProvidersContract: "v1beta1",
243-
// Note: Both InitWithKubernetesVersion and WorkloadKubernetesVersion should be the highest mgmt cluster version supported by the source Cluster API version.
244-
InitWithKubernetesVersion: "v1.30.0",
245-
WorkloadKubernetesVersion: "v1.30.0",
246-
MgmtFlavor: "topology",
247-
WorkloadFlavor: "",
248-
UseKindForManagementCluster: true,
249-
}
250-
})
251-
})
252-
253221
// Note: This test should be changed during "prepare main branch", it should test n-2 => current.
254222
var _ = Describe("When testing clusterctl upgrades using ClusterClass (v1.7=>current) [ClusterClass]", func() {
255223
// Get v1.7 latest stable release
@@ -282,32 +250,6 @@ var _ = Describe("When testing clusterctl upgrades using ClusterClass (v1.7=>cur
282250
})
283251
})
284252

285-
// Note: This test should be changed during "prepare main branch", it should test n-1 => current.
286-
var _ = Describe("When testing clusterctl upgrades (v1.8=>current)", func() {
287-
// Get v1.8 latest stable release
288-
version := "1.8"
289-
stableRelease, err := GetStableReleaseOfMinor(ctx, version)
290-
Expect(err).ToNot(HaveOccurred(), "Failed to get stable version for minor release : %s", version)
291-
ClusterctlUpgradeSpec(ctx, func() ClusterctlUpgradeSpecInput {
292-
return ClusterctlUpgradeSpecInput{
293-
E2EConfig: e2eConfig,
294-
ClusterctlConfigPath: clusterctlConfigPath,
295-
BootstrapClusterProxy: bootstrapClusterProxy,
296-
ArtifactFolder: artifactFolder,
297-
SkipCleanup: skipCleanup,
298-
InfrastructureProvider: ptr.To("docker"),
299-
InitWithBinary: fmt.Sprintf(clusterctlDownloadURL, stableRelease),
300-
InitWithProvidersContract: "v1beta1",
301-
// Note: Both InitWithKubernetesVersion and WorkloadKubernetesVersion should be the highest mgmt cluster version supported by the source Cluster API version.
302-
InitWithKubernetesVersion: "v1.31.0",
303-
WorkloadKubernetesVersion: "v1.31.0",
304-
MgmtFlavor: "topology",
305-
WorkloadFlavor: "",
306-
UseKindForManagementCluster: true,
307-
}
308-
})
309-
})
310-
311253
// Note: This test should be changed during "prepare main branch", it should test n-1 => current.
312254
var _ = Describe("When testing clusterctl upgrades using ClusterClass (v1.8=>current) [ClusterClass]", func() {
313255
// Get v1.8 latest stable release

test/e2e/self_hosted_test.go

-13
Original file line numberDiff line numberDiff line change
@@ -24,19 +24,6 @@ import (
2424
"k8s.io/utils/ptr"
2525
)
2626

27-
var _ = Describe("When testing Cluster API working on self-hosted clusters", func() {
28-
SelfHostedSpec(ctx, func() SelfHostedSpecInput {
29-
return SelfHostedSpecInput{
30-
E2EConfig: e2eConfig,
31-
ClusterctlConfigPath: clusterctlConfigPath,
32-
BootstrapClusterProxy: bootstrapClusterProxy,
33-
ArtifactFolder: artifactFolder,
34-
SkipCleanup: skipCleanup,
35-
InfrastructureProvider: ptr.To("docker"),
36-
}
37-
})
38-
})
39-
4027
var _ = Describe("When testing Cluster API working on self-hosted clusters using ClusterClass [ClusterClass]", func() {
4128
SelfHostedSpec(ctx, func() SelfHostedSpecInput {
4229
return SelfHostedSpecInput{

0 commit comments

Comments
 (0)