Skip to content

🌱 Remove redundant self-hosted and clusterctl upgrade tests #11073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
This PR drops redundant e2e tests. Over the last few months/years we continuously added more e2e tests. Now we reached a test duration of over 2 hours.

This PR will already significantly improve the situation: #11067. But I think additionally we should also only run the e2e tests we actually need

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 20, 2024
@sbueringer sbueringer added area/e2e-testing Issues or PRs related to e2e testing and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 20, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-area PR is missing an area label labels Aug 20, 2024
@@ -24,19 +24,6 @@ import (
"k8s.io/utils/ptr"
)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage this test provides is a subset of When testing Cluster API working on self-hosted clusters using ClusterClass [ClusterClass]

@@ -218,38 +218,6 @@ var _ = Describe("When testing clusterctl upgrades (v1.0=>current)", func() {
})
})

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are a subset of the corresponding tests with ClusterClass

@sbueringer
Copy link
Member Author

/assign @fabriziopandini @chrischdi

@chrischdi
Copy link
Member

/lgtm

/hold to not merge it too quickly :-)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 073a23904da1f3d8f43367a1d07e4412ea63d54a

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 20, 2024
@sbueringer
Copy link
Member Author

/hold cancel

If anyone has concerns, please let me know. Happy to follow-up if necessary!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2024
@chrischdi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3b1f713 into kubernetes-sigs:main Aug 22, 2024
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants