-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 Remove redundant self-hosted and clusterctl upgrade tests #11073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove redundant self-hosted and clusterctl upgrade tests #11073
Conversation
Signed-off-by: Stefan Büringer [email protected]
@@ -24,19 +24,6 @@ import ( | |||
"k8s.io/utils/ptr" | |||
) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage this test provides is a subset of When testing Cluster API working on self-hosted clusters using ClusterClass [ClusterClass]
@@ -218,38 +218,6 @@ var _ = Describe("When testing clusterctl upgrades (v1.0=>current)", func() { | |||
}) | |||
}) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are a subset of the corresponding tests with ClusterClass
/assign @fabriziopandini @chrischdi |
/lgtm /hold to not merge it too quickly :-) |
LGTM label has been added. Git tree hash: 073a23904da1f3d8f43367a1d07e4412ea63d54a
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
/hold cancel If anyone has concerns, please let me know. Happy to follow-up if necessary! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This PR drops redundant e2e tests. Over the last few months/years we continuously added more e2e tests. Now we reached a test duration of over 2 hours.
This PR will already significantly improve the situation: #11067. But I think additionally we should also only run the e2e tests we actually need
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #