Skip to content

move the generate_fake content_to deployer.py #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2025
Merged

move the generate_fake content_to deployer.py #2430

merged 4 commits into from
Jun 4, 2025

Conversation

Qianh1225
Copy link
Contributor

No description provided.

@Qianh1225 Qianh1225 requested a review from talsperre May 28, 2025 00:10
@savingoyal savingoyal requested a review from madhur-ob May 29, 2025 16:19
madhur-ob
madhur-ob reviewed Jun 2, 2025
View reviewed changes
madhur-ob
madhur-ob requested changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@madhur-ob madhur-ob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it is not a simple move since param_python_var_name = param_details["python_var_name"] is missing

@talsperre talsperre merged commit 7bb99bf into master Jun 4, 2025
29 checks passed
@talsperre talsperre deleted the move_fake_content branch June 4, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talsperre talsperre talsperre approved these changes

@madhur-ob madhur-ob madhur-ob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qianh1225 @talsperre @madhur-ob