Skip to content

WIP: RDS: add engineVersion attribute #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RaitoBezarius
Copy link
Member

This adds the engine version attribute (e.g. PostgreSQL 12, etc.)

This PR only require I make the attribute optional so that it is backward compatible.

@RaitoBezarius RaitoBezarius marked this pull request as draft October 10, 2021 15:52
@tewfik-ghariani
Copy link
Contributor

I believe it should also be added to :

class Ec2RdsDbinstanceOptions(ResourceOptions):

Also, I would suggest to adapt the boto3 port work done per #120 and add this particular change ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants