Skip to content

Why acpi_call? #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghtau opened this issue Sep 9, 2024 · 3 comments · Fixed by #1266
Closed

Why acpi_call? #1114

ghtau opened this issue Sep 9, 2024 · 3 comments · Fixed by #1266

Comments

@ghtau
Copy link

ghtau commented Sep 9, 2024

TLP's documentation states:

As of version 5.17, the Linux kernel in combination with TLP 1.5 or later offers full battery care support (i.e. charge thresholds and recalibration) for ThinkPads from model year 2011 onwards.

...and later even calls acpi_call "obsolete".

So I'm curious why it's used and why the module states that it "makes tlp work for newer thinkpads"? The natacpi + thinkpad_acpi combo works for me on older Thinkpads (e.g. X230) and my more recent ones (e.g. T470s).
@Mic92
Copy link
Member

Mic92 commented Sep 9, 2024

It's probably fair to remove it at this point.

@jrasanen
Copy link

jrasanen commented Dec 2, 2024

I noticed I'm unable to build NixOS with the latest ACPI call, here's a thread I opened on Discourse, with some findings from the community members (thanks Simon!)

Mic92 added a commit that referenced this issue Dec 2, 2024
@Mic92
drop acpi_call from nixos-hardware
9f27d9a 
fixes #1114 and tlp also
no longer recommands it.
@Mic92 Mic92 mentioned this issue Dec 2, 2024
Merged
2 tasks
@Mic92 Mic92 closed this as completed in 38dc37f Dec 2, 2024
Mic92 added a commit that referenced this issue Dec 2, 2024
@Mic92
drop acpi_call from nixos-hardware
c6c9088 
fixes #1114 and tlp also
no longer recommands it.
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/hash-mismatch-issue/56870/6

pschmitt added a commit to pschmitt/nixos-config that referenced this issue Dec 3, 2024
@pschmitt
Remove acpi_call: NixOS/nixos-hardware#1114
dbcc621
cu1ch3n added a commit to cu1ch3n/nixbook that referenced this issue Dec 5, 2024
@cu1ch3n
common-pc-laptop-acpi_call has been removed because it is obsolete: N…
2204db4 
…ixOS/nixos-hardware#1114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drop acpi_call from nixos-hardware NixOS/nixos-hardware
4 participants
@jrasanen @Mic92 @nixos-discourse @ghtau