E14-intel: import intel comet lake #1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
force-pushed
the
e14-intel
branch
from
1a3067b to
87656d7
Compare
Mic92
reviewed
Dec 6, 2024
| ]; | ||
|
|
||
| hardware.intelgpu.vaapiDriver = "intel-media-driver"; |
There was a problem hiding this comment.
Do we not set this in the intel module? Maybe we should.
There was a problem hiding this comment.
As far as I understood it, it by default pulls in intel-media-driver and intel-vaapi-driver but I don't think we need the later.
There was a problem hiding this comment.
We have several intel generation profiles configuring intel-media-driver. If this is the right one for intel comet lake, we should do the same.
The E14 has a i5-10210U which is from comet lake. see https://www.intel.com/content/www/us/en/products/sku/195436/intel-core-i510210u-processor-6m-cache-up-to-4-20-ghz/specifications.html
It is new enough that we don't need or want intel-vaapi-driver.
SuperSandro2000
force-pushed
the
e14-intel
branch
from
87656d7 to
085c9ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E14 has a i5-10210U which is from comet lake.
see https://www.intel.com/content/www/us/en/products/sku/195436/intel-core-i510210u-processor-6m-cache-up-to-4-20-ghz/specifications.html
Description of changes
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input