Feature.asus zephyrus g16 gu605 my backlight and keyboard rules

[relief-melone]

Description of changes

Things done

• Tested the changes in your own NixOS Configuration
• Tested the changes end-to-end by using your fork of nixos-hardware and
  importing it via <nixos-hardware> or Flake input

[Moraxyc]

It seems that brightness adjustment works fine when running on dGPU only. However, I haven’t tested this personally (currently on vacation, will try it when I get back). If anyone can test and confirm this, perhaps we should add a lib.mkIf to add these kernel parameters only when using gGPU hybrid mode.

reference: https://www.ehmiiz.se/blog/linux_asus_g16_2024/

[relief-melone]

would also lite to test it out. would prefer to test it with an up do date nixpkgs commit though and the current one has issues with my printer as well as some nvim features.
would want to wait for the next publish here

[Mic92]

@Moraxyc still on vacation?

[Moraxyc]

I tried to use only dgpu without adding these kernel parameters, and the backlight control was normal. So the answer is that we should determine whether to add these kernel parameters based on whether only dgpu is working. However, I don't know how to switch to dgpu-only state in nxios configurations. I entered the bios to switch manually, and the following content seems to be useless

    specialisation.dgpu-only.configuration = {
      disabledModules = [
        # Containing `boot.kernelParams = [];`
        ./brightness.nix
      ];
      system.nixos.tags = [ "dgpu-only" ];
      services.xserver.exportConfiguration = true;

      services.xserver = {
        videoDrivers = lib.mkForce [ "nvidia" ];
      };

      hardware = {
        nvidia = {
          powerManagement.enable = lib.mkForce false;
          modesetting.enable = true;
          prime = {
            offload.enable = lib.mkForce false;
            sync.enable = true;
          };
        };
      };
    };

[Mic92]

@Moraxyc So should we merge this?

[Moraxyc]

@relief-melone Please add a comment to show that these parameters are used to enable backlight control when the dGPU is working in hybrid mode.

After this, I think we can get the PR merged.

[Mic92]

Please undraft when the change is done.

[phanirithvij]

friendly ping @relief-melone

[Mic92]

@Mergifyio queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

The pull request #1308 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

[Mic92]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at f1e52a0