Skip to content

feat: add kernel switching for Microsoft Surface devices #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 24, 2025

Conversation

8bitbuddhist
Copy link
Contributor

@8bitbuddhist 8bitbuddhist commented Apr 12, 2025

Description of changes

This PR adds the ability to choose between the most recent long term support kernel and the most recent stable kernel for Microsoft Surface devices (6.12 and 6.14 as of this writing). This originated from this PR and the need for some users to stay on older kernel versions while waiting for modules to catch up. This also makes kernel updates slightly easier, since the versions and hashes have been moved into a single file (microsoft/surface/common/default.nix).

Things done
  • Tested the changes in your own NixOS Configuration (currently using it with the stable kernel)
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@8bitbuddhist 8bitbuddhist marked this pull request as draft April 12, 2025 14:55
@8bitbuddhist 8bitbuddhist changed the title feat: add kernel switching for Microsoft Surface devices (WIP) feat: add kernel switching for Microsoft Surface devices Apr 12, 2025
@8bitbuddhist
Copy link
Contributor Author

8bitbuddhist commented Apr 12, 2025

Added a fix to separate the source kernel version from the linux-surface release version.

@8bitbuddhist 8bitbuddhist changed the title (WIP) feat: add kernel switching for Microsoft Surface devices feat: add kernel switching for Microsoft Surface devices Apr 12, 2025
@8bitbuddhist 8bitbuddhist marked this pull request as ready for review April 12, 2025 16:38
@Mic92
Copy link
Member

Mic92 commented Apr 23, 2025

cc @matthiasdotsh

Add `hardware` to option name

Co-authored-by: Jörg Thalheim <[email protected]>
@8bitbuddhist 8bitbuddhist force-pushed the surface/kernel-multiple-versions branch from 2e1e121 to 34f02c3 Compare April 23, 2025 14:14
@matthiasdotsh
Copy link
Contributor

matthiasdotsh commented Apr 23, 2025

I just tried the code with the default settings (longterm kernel) and its failing with an error similar to #1436

@8bitbuddhist
Copy link
Contributor Author

8bitbuddhist commented Apr 23, 2025

I just tried the code with the default settings (longterm kernel) and its failing with an error similar to #1436

My mistake, I was troubleshooting #1436 and it made its way into this one. I reverted to 6.12.19 (the current version in master) and rebuilt it to make sure.

@matthiasdotsh
Copy link
Contributor

I reverted to 6.12.19 (the current version in master) and rebuilt it to make sure.

Thanks, I can confirm that this version is still building!

All in all this looks very good to me, thanks for your work!

@Mic92 Mic92 merged commit f7bee55 into NixOS:master Apr 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants