Skip to content

Spec links to https://path.id - v3.2.0 #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Bellangelo
Copy link
Member

Closes #3679

v3.1.1 PR: #3707
v3.0.4 PR: #3706

@mikekistler
Copy link
Contributor

@Bellangelo This PR seems to have dragged in a few more changes than the other two, which were just the one line fix for "path.id". Is this intentional? If yes please explain what these changes are for, and if not please fix.

@Bellangelo Bellangelo changed the base branch from main to v3.2.0-dev April 15, 2024 12:58
@Bellangelo
Copy link
Member Author

@Bellangelo This PR seems to have dragged in a few more changes than the other two, which were just the one line fix for "path.id". Is this intentional? If yes please explain what these changes are for, and if not please fix.

Hi @mikekistler, the change is correct but I had set the wrong branch to be merged at. Please check again.

Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@lornajane
Copy link
Contributor

Renders perfectly, thank you!

@lornajane lornajane merged commit 55fb99a into OAI:v3.2.0-dev Apr 18, 2024
@handrews handrews added this to the v3.2.0 milestone May 17, 2024
@handrews handrews added the bug label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec links to https://path.id
5 participants