Skip to content

Explicitly state what security: [] means #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rvedotrc
Copy link

@rvedotrc rvedotrc commented Aug 5, 2024

It's currently not clear from the spec what security: [] means. It's stated that it's allowed, but it doesn't say what it does. Obvious guesses are that it either authorizes everything, or that it authorizes nothing; but it's not stated which.

As per #3938, I'm told that the answer is "authorize everything"; so this PR seeks to make that explicit.

On the other hand, if that answer is incorrect, please let me know what [] in fact means, and I'll see if I can update this PR accordingly.

See also: #3995.

@rvedotrc rvedotrc marked this pull request as ready for review August 5, 2024 08:32
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to add a new feature, which we can't do in a patch release.

Please consider re-targeting this PR to the v3.2.0-dev branch.

@rvedotrc
Copy link
Author

rvedotrc commented Aug 5, 2024

I'm not sure what you mean by "adding a new feature" here, so I'll ask you to be a bit more black and white, if I may: are you saying that this rewording (or some variation of it) will not be accepted into 3.1, but could be OK in 3.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants