Skip to content

v3.1-dev: resolve conflicts that prevent a direct merge from dev #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 13, 2025

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Mar 6, 2025

This PR reverts changes in branch v3.1-dev that prevent updating it from main.

Merging this PR will unblock the sync PR

This dummy PR from dev into v3.1-dev-resolve-conflicts proves that dev can be merged without conflicts into the commit history of this branch:

@ralfhandl ralfhandl marked this pull request as ready for review March 6, 2025 22:19
@ralfhandl ralfhandl requested review from a team as code owners March 6, 2025 22:19
@ralfhandl ralfhandl requested a review from lornajane March 6, 2025 22:28
Comment on lines -217 to -221
### Field Names and Values in YAML comments

Field names and keywords should be in backticks.
Values like "Dog" should be double quoted.

Copy link
Contributor Author

@ralfhandl ralfhandl Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section was added to the style guide in main and should never have been added to this outdated state of CONTRIBUTING.md. Removing it resolves the conflict.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this change did make it into main over in style-guide.md. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was removed on dev and changed on v3.1-dev. Removing it resolves the conflict.

@ralfhandl ralfhandl mentioned this pull request Mar 7, 2025
11 tasks
@handrews handrews merged commit c4cf1f2 into v3.1-dev Mar 13, 2025
6 checks passed
@ralfhandl ralfhandl deleted the v3.1-dev-resolve-conflicts branch March 13, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants