-
Notifications
You must be signed in to change notification settings - Fork 9.1k
v3.1-dev: resolve conflicts that prevent a direct merge from dev #4417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
### Field Names and Values in YAML comments | ||
|
||
Field names and keywords should be in backticks. | ||
Values like "Dog" should be double quoted. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section was added to the style guide in main
and should never have been added to this outdated state of CONTRIBUTING.md
. Removing it resolves the conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this change did make it into main
over in style-guide.md
. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was removed on dev
and changed on v3.1-dev
. Removing it resolves the conflict.
This PR reverts changes in branch
v3.1-dev
that prevent updating it from main.Merging this PR will unblock the sync PR
This dummy PR from
dev
intov3.1-dev-resolve-conflicts
proves thatdev
can be merged without conflicts into the commit history of this branch: