Skip to content

[FIX] _mark_migration_done_in_migration_issue : Call _find_issue with correct number of parameters #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2023
Merged

[FIX] _mark_migration_done_in_migration_issue : Call _find_issue with correct number of parameters #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/oca_github_bot/tasks/migration_issue_bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ def _set_lines_issue(gh_pr_user_login, gh_pr_number, issue_body, module):


def _mark_migration_done_in_migration_issue(gh_repo, target_branch, gh_pr):
migration_issue = _find_issue(gh_repo, target_branch)
milestone = _create_or_find_branch_milestone(gh_repo, target_branch)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't create the milestone.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it does no harm in practice. Merging to unblock the situation.

migration_issue = _find_issue(gh_repo, milestone, target_branch)
if migration_issue:
new_body = _check_line_issue(gh_pr.number, migration_issue.body)
migration_issue.edit(body=new_body)
Expand Down