Skip to content

'-' and '_' may be treated in plain letters. #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

yangbongsoo
Copy link
Contributor

#193 becaue of _ char, order string find it in ENTITY_TRIE and replace
I think - and _ may be treated in plain letters.
Please tell me if you think I'm wrong or if I lack a test.

@mikesamuel
Copy link
Contributor

mikesamuel commented Jun 1, 2020

Hmm. Since this was initially written, https://html.spec.whatwg.org/#named-character-references clarified which named character references are allowed without a trailing semicolon.

I believe, according to html.spec.whatwg, that &curren is allowed without a semicolon because there are two entries in that table, one of which does not have a trailing ;:

Name Character Glyph
curren; U+000A4 ¤
curren U+000A4 ¤

Maybe we should just derive a list of HTML entities that are allowed without semicolons instead of looking for extra letters.

@mikesamuel
Copy link
Contributor

Does #201 do what you need?

@yangbongsoo
Copy link
Contributor Author

yes. I close this PR.

@yangbongsoo yangbongsoo closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants