Skip to content

Fix precompile insertion #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Fix precompile insertion #10

merged 2 commits into from
Oct 27, 2021

Conversation

hkalodner
Copy link
Contributor

No description provided.

Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As-is I think this breaks normal ethereum precompiles

@hkalodner hkalodner requested a review from PlasmaPower October 27, 2021 17:19
Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting on the nitro side to merge

@PlasmaPower PlasmaPower merged commit 6acb1bd into master Oct 27, 2021
@PlasmaPower PlasmaPower deleted the fix-precompile-insert branch October 27, 2021 17:39
rauljordan pushed a commit to rauljordan/go-ethereum that referenced this pull request Oct 20, 2022
The List and Vector sizes were different from the spec.

Also fixed bug in hash_to_bls field where the merkle root used for
the fiat-shamir was interpreted as big-endian
zfy0701 pushed a commit to sentioxyz/nitro-geth that referenced this pull request Mar 11, 2024
zfy0701 pushed a commit to sentioxyz/nitro-geth that referenced this pull request Mar 11, 2024
rachel-bousfield added a commit that referenced this pull request Apr 19, 2024
zfy0701 added a commit to sentioxyz/nitro-geth that referenced this pull request Apr 24, 2024
migrate override and gas changes (OffchainLabs#1)

migrate memory compression (OffchainLabs#2)

add more information for root trace (OffchainLabs#3)

correct handle call with value (OffchainLabs#4)

* correct handle call with value

* set transfer value to zero if can't transfer

Add Mapping keys to post account (OffchainLabs#5)

fix when tracer failed before start (OffchainLabs#6)

unlimited gas for debug_traceCallMany (OffchainLabs#7)

support multiple txs in tracecallmany

rpc client should keep result while return error

be able to return partial results

migrate tracer changes (OffchainLabs#8)

export meq field (OffchainLabs#9)

ignore init code size limit (OffchainLabs#10)

code address field (OffchainLabs#11)

minor fix (OffchainLabs#12)

fix type compat (OffchainLabs#13)

fix compability with arb

fix storagerangeat

emit output for revert (OffchainLabs#14)
zfy0701 added a commit to sentioxyz/nitro-geth that referenced this pull request Jun 23, 2024
migrate override and gas changes (OffchainLabs#1)

migrate memory compression (OffchainLabs#2)

add more information for root trace (OffchainLabs#3)

correct handle call with value (OffchainLabs#4)

* correct handle call with value

* set transfer value to zero if can't transfer

Add Mapping keys to post account (OffchainLabs#5)

fix when tracer failed before start (OffchainLabs#6)

unlimited gas for debug_traceCallMany (OffchainLabs#7)

support multiple txs in tracecallmany

rpc client should keep result while return error

be able to return partial results

migrate tracer changes (OffchainLabs#8)

export meq field (OffchainLabs#9)

ignore init code size limit (OffchainLabs#10)

code address field (OffchainLabs#11)

minor fix (OffchainLabs#12)

fix type compat (OffchainLabs#13)

fix compability with arb

fix storagerangeat

emit output for revert (OffchainLabs#14)
zfy0701 added a commit to sentioxyz/nitro-geth that referenced this pull request Jun 23, 2024
migrate override and gas changes (OffchainLabs#1)

migrate memory compression (OffchainLabs#2)

add more information for root trace (OffchainLabs#3)

correct handle call with value (OffchainLabs#4)

* correct handle call with value

* set transfer value to zero if can't transfer

Add Mapping keys to post account (OffchainLabs#5)

fix when tracer failed before start (OffchainLabs#6)

unlimited gas for debug_traceCallMany (OffchainLabs#7)

support multiple txs in tracecallmany

rpc client should keep result while return error

be able to return partial results

migrate tracer changes (OffchainLabs#8)

export meq field (OffchainLabs#9)

ignore init code size limit (OffchainLabs#10)

code address field (OffchainLabs#11)

minor fix (OffchainLabs#12)

fix type compat (OffchainLabs#13)

fix compability with arb

fix storagerangeat

emit output for revert (OffchainLabs#14)
zfy0701 added a commit to sentioxyz/nitro-geth that referenced this pull request Jul 2, 2024
migrate override and gas changes (OffchainLabs#1)

migrate memory compression (OffchainLabs#2)

add more information for root trace (OffchainLabs#3)

correct handle call with value (OffchainLabs#4)

* correct handle call with value

* set transfer value to zero if can't transfer

Add Mapping keys to post account (OffchainLabs#5)

fix when tracer failed before start (OffchainLabs#6)

unlimited gas for debug_traceCallMany (OffchainLabs#7)

support multiple txs in tracecallmany

rpc client should keep result while return error

be able to return partial results

migrate tracer changes (OffchainLabs#8)

export meq field (OffchainLabs#9)

ignore init code size limit (OffchainLabs#10)

code address field (OffchainLabs#11)

minor fix (OffchainLabs#12)

fix type compat (OffchainLabs#13)

fix compability with arb

fix storagerangeat

emit output for revert (OffchainLabs#14)
zfy0701 added a commit to sentioxyz/nitro-geth that referenced this pull request Sep 2, 2024
migrate override and gas changes (OffchainLabs#1)

migrate memory compression (OffchainLabs#2)

add more information for root trace (OffchainLabs#3)

correct handle call with value (OffchainLabs#4)

* correct handle call with value

* set transfer value to zero if can't transfer

Add Mapping keys to post account (OffchainLabs#5)

fix when tracer failed before start (OffchainLabs#6)

unlimited gas for debug_traceCallMany (OffchainLabs#7)

support multiple txs in tracecallmany

rpc client should keep result while return error

be able to return partial results

migrate tracer changes (OffchainLabs#8)

export meq field (OffchainLabs#9)

ignore init code size limit (OffchainLabs#10)

code address field (OffchainLabs#11)

minor fix (OffchainLabs#12)

fix type compat (OffchainLabs#13)

fix compability with arb

fix storagerangeat

emit output for revert (OffchainLabs#14)
zfy0701 added a commit to sentioxyz/nitro-geth that referenced this pull request Sep 26, 2024
migrate override and gas changes (OffchainLabs#1)

migrate memory compression (OffchainLabs#2)

add more information for root trace (OffchainLabs#3)

correct handle call with value (OffchainLabs#4)

* correct handle call with value

* set transfer value to zero if can't transfer

Add Mapping keys to post account (OffchainLabs#5)

fix when tracer failed before start (OffchainLabs#6)

unlimited gas for debug_traceCallMany (OffchainLabs#7)

support multiple txs in tracecallmany

rpc client should keep result while return error

be able to return partial results

migrate tracer changes (OffchainLabs#8)

export meq field (OffchainLabs#9)

ignore init code size limit (OffchainLabs#10)

code address field (OffchainLabs#11)

minor fix (OffchainLabs#12)

fix type compat (OffchainLabs#13)

fix compability with arb

fix storagerangeat

emit output for revert (OffchainLabs#14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants