Skip to content

RetrieveModelDetailsAsync has an overload that takes an auth parameter it ignores #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KeithHenry opened this issue Feb 15, 2023 · 1 comment · May be fixed by #44
Closed

RetrieveModelDetailsAsync has an overload that takes an auth parameter it ignores #42

KeithHenry opened this issue Feb 15, 2023 · 1 comment · May be fixed by #44

Comments

@KeithHenry
Copy link

Here:

OpenAI-API-dotnet/OpenAI_API/Model/ModelsEndpoint.cs

Line 48 in 97fb71b

public async Task<Model> RetrieveModelDetailsAsync(string id, APIAuthentication auth = null)

KeithHenry added a commit to KeithHenry/OpenAI-API-dotnet that referenced this issue Feb 15, 2023
@KeithHenry
fix: deprecate overload that ignores param
e6155b4 
closes OkGoDoIt#42
@KeithHenry KeithHenry mentioned this issue Feb 15, 2023
Open
OkGoDoIt added a commit that referenced this issue Feb 16, 2023
@OkGoDoIt
Fix #47, #43, and #42, plus adds Usage stats to results
7755f4c
@OkGoDoIt
Copy link
Owner

Good catch. This is leftover from a previous implementation before refactoring. I have implemented your suggested fix in 7755f4c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Dependency Injection KeithHenry/OpenAI-API-dotnet
2 participants
@OkGoDoIt @KeithHenry