Read band metadata from item-asset extension in STAC collection if possible #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and metadata from assets if necessary Open-EO#553
soxofaan
reviewed
May 3, 2024
| @@ -546,32 +546,47 @@ def get_band_names(bands: List[Band]) -> List[str]: | |||
| def is_band_asset(asset: pystac.Asset) -> bool: | |||
| return "eo:bands" in asset.extra_fields | |||
|
|
|||
| def bands_from_collection(collection: pystac.Collection) -> List[Band]: | |||
| # First check if the item_asset extension is present, if so, we can use that to get the band metadata | |||
| if pystac.extensions.item_assets.ItemAssetsExtension.has_extension(collection): | |||
There was a problem hiding this comment.
does this work? pystac.extensions.item_assets is not imported yet I think
|
Support for item-assets was also introduced by PR #577 so this one can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
metadata_from_stacsuch that if the item-asset extension is present in a STAC collection, the client reads the band metadata from there instead of looping over all the assets.