typescript-node: Reject Promises in using Error instances instead of plain objects

[ghost]

Is your feature request related to a problem? Please describe.

In generated typescript code promises are rejected with plain objects instead of error instances.
By not using errors we loose stacktraces and thus easy debugging.

Describe the solution you'd like

Reject Promises with proper Error instances. This would be done here:

openapi-generator/modules/openapi-generator/src/main/resources/typescript-node/api-single.mustache

Line 225 in e73bf9b

reject({ response: response, body: body });

I can provide a PR, if you are going to accept it. This would be a breaking change.
I would add a new HttpError class with a statusCode property. Additionally We can add body and response. This would be a breaking change, but in my opinion a good one.

Describe alternatives you've considered

I don't think there is any viable alternative

Additional context

I come from kubernetes-client/javascript#336

[macjohnny]

if your proposed new HttpError class contains the properties body and response, it isn't a breaking change and thus could be included soon. so go ahead and file a PR.

[keesvanlierop]

@macjohnny @aeb-sia If I'm not mistaken, the suggested improvement was pushed to 4.1.3 before making sure that body and response were included.

Without it, you cannot get any error context anymore about a failed request in your implementation. As you've suggested, we need to add those two properties to the HttpError class.

[macjohnny]

@keesvanlierop feel free to file a PR if you suggest a change

[ghost]

@keenerthanyou actually dc2907a includes body, response and even statusCode

[keesvanlierop]

It accepts body and response in the constructor of HttpError, it doesn't actually do anything with it, right?

[ghost]

they are all using public in the constructor, so you can access them

[keesvanlierop]

You are right!