Skip to content

[Python] pass api_client configuration to model deserialize #13922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

juliantaylor
Copy link
Contributor

@juliantaylor juliantaylor commented Nov 4, 2022

The if not passed the models create a new configuration object which configures logging and determines cpu count every time. This causes extreme performance issues when deserializing larger sets of items.

See also
kubernetes-client/python#1921

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@juliantaylor
Copy link
Contributor Author

@spacether

this should also be added to older versions if you still support them as the kubernetes/python library is still on an older version of the generator

@spacether
Copy link
Contributor

I am checking to see if we rev roll old versions. I don't think that we do. If that is true then your project could

  • wait for this to be merged and update to the next released version of our tool with python-legacy as the generator
  • or patch the generated (old) client to include this fix in your repo

The if not passed the models create a new configuration object which
configures logging and determines cpu count every time.
This causes extreme performance issues when deserializing larger sets of
items.

See also
kubernetes-client/python#1921
@juliantaylor juliantaylor force-pushed the fix-python-reconfiguration branch from bafb280 to 1cc93a4 Compare November 6, 2022 14:19
@juliantaylor
Copy link
Contributor Author

added the samples, (misinterpreted the output of the action results though it was fine)

@spacether spacether added this to the 6.3.0 milestone Nov 6, 2022
@wing328
Copy link
Member

wing328 commented Nov 7, 2022

this should also be added to older versions if you still support them as the kubernetes/python library is still on an older version of the generator

We do not support the old version. Users should upgrade to newer versions instead.

Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the PR!

@spacether spacether merged commit 3dc8403 into OpenAPITools:master Nov 7, 2022
@juliantaylor juliantaylor deleted the fix-python-reconfiguration branch November 7, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants