Skip to content

Fixes javadoc warnings in GenApiDelegate #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jimschubert
Copy link
Member

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This fixes javadoc warnings in GenApiDelegate only. see #63. Comments on the PR suggest the remaining 4 warnings are fixed in other open PRs.

@jmini jmini merged commit 22e94fb into OpenAPITools:master May 24, 2018
@cbornet
Copy link
Member

cbornet commented Jun 7, 2018

The commit Lv-Yi@d9fe34a removed all the java samples test code !!

@wing328
Copy link
Member

wing328 commented Jun 7, 2018

@cbornet we definitely need to restore those test code. I probably missed it when reviewing the PRs. Sorry.

@jmini can you please take a look?

@jmini
Copy link
Member

jmini commented Jun 7, 2018

This has nothing to do with this PR. I have filed #247

@jimschubert jimschubert deleted the fix-GenApiDelegate-javadoc-warnings branch June 12, 2018 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants