#14325 [csharp] - Add CancellationToken to generated aspnetcore controller methods. #14326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #14325. The change adds a
CancellationToken
to all generated aspnetcore controller methods. The change can be verified by updating/bin/configs/aspnetcore-3.0.yaml
with the below and generating the samples. Without these settings, the generated samples are unchanged:The
CancellationToken
is automatically bound as described in issue #14325 and therefore does not require any other changes and consumers can continue to use the API as normal@wing328 @mandrean @shibayan @Blackclaws @lucamazzanti
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)