Skip to content

Creating regex for our generators which will allow the bot to au… #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 17, 2018
Merged

Creating regex for our generators which will allow the bot to au… #1639

merged 4 commits into from
Dec 17, 2018

Conversation

jimschubert
Copy link
Member

…tomatically label issues and PRs

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

I've created a bot (https://github.com/jimschubert/auto-labeler) and installed it in this repo. This config is the start of regex for auto-labeling Issues and PRs via the bot.

@jimschubert jimschubert added the WIP Work in Progress label Dec 9, 2018
@jimschubert jimschubert mentioned this pull request Dec 9, 2018
Open
@jimschubert jimschubert changed the title WIP: creating regex for our generators which will allow the bot to au… Creating regex for our generators which will allow the bot to au… Dec 9, 2018
@jimschubert
Copy link
Member Author

I've added tests to verify labels as they would be applied to our sample generation scripts (simulating someone including the command line options in an open Issue/PR).

I think this should be good to go in after review. Question: Should we hook up the test script to CI?

@jimschubert
Copy link
Member Author

@wing328 @jmini I have assigned a few "new" labels, but wanted some feedback:

Schema: GraphQL
Documentation: Cwiki
Documentation: Dynamic HTML

These don't seem to exist in GitHub at the moment.

Is it appropriate to call the graphql generator (not the server one) a "Schema" generator?

Is it correct to consider Cwiki and Dynamic HTML to be Documentation generators? If so, should we rename Client: HTML to Documentation: HTML?

@wing328
Copy link
Member

wing328 commented Dec 13, 2018

Is it appropriate to call the graphql generator (not the server one) a "Schema" generator?

Yup, that's why I created the "Schema: GraphQL" label.

Is it correct to consider Cwiki and Dynamic HTML to be Documentation generators? If so, should we rename Client: HTML to Documentation: HTML?

Yup, please go ahead with the label renaming. One minor suggestion is to use "Doc: HTML" to make the label shorter.

@wing328 wing328 merged commit 2025d12 into master Dec 17, 2018
@wing328 wing328 added this to the 4.0.0 milestone Dec 17, 2018
@jimschubert jimschubert deleted the auto-labeler-config branch December 19, 2018 20:23
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@jimschubert @wing328
Creating regex for our generators which will allow the bot to au… (Op…
7f29ccd 
…enAPITools#1639)

* WIP: creating regex for our generators which will allow the bot to automatically label issues and PRs

* Include additional WIP regex

* Remainder of implemented generators

* Add tests for regex in auto labeling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wing328 wing328 wing328 approved these changes

Assignees
No one assigned
Labels
Enhancement: CI/Test Enhancement: General
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jimschubert @wing328