Skip to content

[php] Set $multipart to true if content-type is multipart/form-data (#5536) #18991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2024
Merged

[php] Set $multipart to true if content-type is multipart/form-data (#5536) #18991

merged 3 commits into from
Dec 15, 2024

Conversation

simonhammes
Copy link
Contributor

The PHP client does not correctly identify multipart/form-data requests without files. See #5536 (comment) for details.
This PR fixes this bug.

Related: #5536

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@simonhammes
Copy link
Contributor Author

@simonhammes simonhammes requested a review from wing328 October 15, 2024 19:35
@wing328 wing328 added this to the 7.11.0 milestone Dec 15, 2024
@wing328 wing328 merged commit 9b3484c into OpenAPITools:master Dec 15, 2024
4 checks passed
@wing328
Copy link
Member

wing328 commented Dec 15, 2024

@simonhammes thanks for the PR, which has been merged.

Sorry for taking a bit long to review.

@simonhammes simonhammes deleted the php-client-fix-multipart-form-data-requests branch December 15, 2024 14:34
@simonhammes
Copy link
Contributor Author

@wing328 Thanks for merging!

Sorry for taking a bit long to review.

No worries 🙂

timon-sbr pushed a commit to timon-sbr/openapi-generator that referenced this pull request Mar 13, 2025
…penAPITools#5536) (OpenAPITools#18991)

* [php] Set $multipart to true if content-type is multipart/form-data (OpenAPITools#5536)

Related: OpenAPITools#5536

* [php] Use isMultipart variable

---------

Co-authored-by: Simon Hammes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants