-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
[feat] [protobuf] Improve protobuf generator with switch useSimplifiedEnumNames #21052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
|
||
private void testEnumValues(boolean simpleEnumValue) { | ||
final Schema model = new Schema() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modelled this test on this one
@@ -84,6 +86,8 @@ public class ProtobufSchemaCodegen extends DefaultCodegen implements CodegenConf | |||
|
|||
private boolean wrapComplexType = true; | |||
|
|||
private boolean simpleEnumName = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to look at the output flip this flag and run the generator, but this is covered by unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also test the output by adding the flag in bin/configs/protobuf-schema-config.yaml .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Good to go @wing328
thanks for the PR cc @lucy66hw as well |
@wing328 ready to go |
#21054
@wing328 we generate wire classes with our protos so we'd like the enum names to be
FOO
rather thanTEST_STRING_ENUM_FOO
. I've added a switch useSimplifiedEnumNames (default old value). Any chance we could get this into the patch?PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)