Fix regex in Python server model code #2314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomghyselinck
changed the title
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Mar 9, 2019
* master: (758 commits) Add support for free form requests (OpenAPITools#2288) [typescript-rxjs] drop unneeded function wrapping (OpenAPITools#2332) [typescript-fetch] Guard array mapping against undefined on optional array model properties (OpenAPITools#2324) Fix regex in Python server model code (OpenAPITools#2314) Add .travis.yml and Gemfile.lock to ruby security test folder (OpenAPITools#2330) Add a link to CSDN article (OpenAPITools#2331) [Maven] fix Spaces in Windows user path breaks build on test goal (OpenAPITools#2318) [PHP] fix bad links in Model docs (OpenAPITools#2316) [java]: fix datatype for non-multipart file request body (OpenAPITools#2271) Removed JFCote from core team (OpenAPITools#2315) [R sample] fix CircleCI error of outdated sample (OpenAPITools#2313) [Java] Bean Validation for decimalmin/max incorrect when exclusive set (OpenAPITools#2115) Java Spring : fix defaultValue annotation double quoted in api operation (OpenAPITools#2267) Java RESTEASY : fix defaultValue annotation double quoted in api operation (OpenAPITools#2268) [PHP] Username checks OpenAPITools#1408 (OpenAPITools#1892) [typescript-fetch] remove namespaces in enums (OpenAPITools#2123) [java-server-msf4j] fix and upgrade (OpenAPITools#2303) fix test script path in CONTRIBUTING.md (OpenAPITools#2290) Dart queryargs (OpenAPITools#2250) add Blueplanet language (OpenAPITools#2184) ...
This was referenced Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
The generated Python server model code incorrectly escapes the regular expressions.
Fixes #1823
The code in the Python client was generated correctly.
Overriding
DefaultCodegen::toRegularExpressionseems to do the trick.The client also overrides
DefaultCodegen::addRegularExpressionDelimiterbut it does not seem to be required. It is even incorrect IMHO (please correct me if I'm wrong).I did tests on a local build with our company's product OpenAPI spec file.
All regular expressions seem to be correct now.