Beta server stub generator for F#/Giraffe #2705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Apr 21, 2019
...penapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractFSharpCodegen.java
Outdated
Show resolved
Hide resolved
wing328
reviewed
Apr 21, 2019
...i-generator/src/main/java/org/openapitools/codegen/languages/FsharpGiraffeServerCodegen.java
Outdated
Show resolved
Hide resolved
use CLI generator work on handlers add binding to url params add parameter declaration to handler & fix array types order models by dependency and add tests add oauth handlers add service generation add service implementation return json for map types and add all return types to service implementation pare down record types for readability move implementations to impl folder fix additional handler invocation remove logging remove open api type provider package reference add sane defaults for OAuth add readme and reorganize files for easier ignore fix oauth checks and move login to default template typedef operation body params as model add API test templates fix test templates set project & other folders when packageName is set add ignore to test pipes add ignore for oauth to hide compile warnings escape model types for generic dictionaries remove Boolean object from primitives fix handler and param templates for multiple path params remove "Model" from model module names and fix import mapping for dictionary add package name to model imports change model templates to use imports move login to CustomHandlers raise exception where oauth not properly configured allow webhost configuration from CustomHandlers remove explicit support for nullable types and render option in template instead move Cookie options to CustomHandlers add header params integrate api key provider add nullable to datetime types fix test generation and pretty up model folder add context path to handler test template dont copy spec file remove superseded copyright notices remove superseded copyright notices
wing328
reviewed
Apr 30, 2019
| <Compile Include="api/params/UrlParams.fs" /> | ||
| <Compile Include="api/params/QueryParams.fs" /> | ||
| <Compile Include="api/params/BodyParams.fs" /> | ||
| <Compile Include="api/params/HeaderParams.fs" /> |
There was a problem hiding this comment.
@nmfisher Looks like these 4 files under api/params are not yet added to the project (templates)
There was a problem hiding this comment.
Actually that directory (samples/server/petstore/fsharp-giraffe/src) was the sample output directory from an earlier revision.
The proper output directory is samples/server/petstore/fsharp-giraffe/{{packageName}} (e.g. samples/server/petstore/fsharp-giraffe/OpenAPI)
I just forgot to remove the earlier version (samples/server/petstore/fsharp-giraffe/src) from the final commit. This is OK to delete - see nmfisher@ee4672e
|
Sorry about the CRLF - will configure git/IDE to stick with LF going forward. |
|
@nmfisher no worries. We've a script to catch these CRLF as part of the CI workflow. |
|
OK. I'll test again. If no more question from me, I'll merge it into the master to release a beta version so as to collect feedback from the community. |
|
Tests passed via https://travis-ci.org/OpenAPITools/openapi-generator/builds/527636181. The CircleCI failure is due to the outdated doc. I'll fix it with another PR after merging this into master.
|
wing328
added a commit
that referenced
this pull request
May 5, 2019
* Beta server stub generator for F#/Giraffe (#2705) * first commit for F#/Giraffe use CLI generator work on handlers add binding to url params add parameter declaration to handler & fix array types order models by dependency and add tests add oauth handlers add service generation add service implementation return json for map types and add all return types to service implementation pare down record types for readability move implementations to impl folder fix additional handler invocation remove logging remove open api type provider package reference add sane defaults for OAuth add readme and reorganize files for easier ignore fix oauth checks and move login to default template typedef operation body params as model add API test templates fix test templates set project & other folders when packageName is set add ignore to test pipes add ignore for oauth to hide compile warnings escape model types for generic dictionaries remove Boolean object from primitives fix handler and param templates for multiple path params remove "Model" from model module names and fix import mapping for dictionary add package name to model imports change model templates to use imports move login to CustomHandlers raise exception where oauth not properly configured allow webhost configuration from CustomHandlers remove explicit support for nullable types and render option in template instead move Cookie options to CustomHandlers add header params integrate api key provider add nullable to datetime types fix test generation and pretty up model folder add context path to handler test template dont copy spec file remove superseded copyright notices remove superseded copyright notices * remove carriage return in fsharp template * remove superseded sample output directory * fix bash build script * update generated sample * update documentation * add new file * fix compile issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
This is a beta server stub generator for F#/Giraffe as discussed in #2342.
Much of the OpenAPI specification is still unsupported, but this is mature enough to open up to the community for discussion/comments/contributions.