Skip to content

[maven-plugin] fix strictSpec parameter #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

jmini
Copy link
Member

@jmini jmini commented Jun 3, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Introduced with #2783, the strictSpec parameter causes the an error in the 4.0.1 maven plugin:

[ERROR] Failed to execute goal org.openapitools:openapi-generator-maven-plugin:4.0.1:generate (generate-client-code): Unable to parse configuration of mojo org.openapitools:openapi-generator-maven-plugin:4.0.1:generate for parameter strictSpec: Cannot find 'strictSpec' in class org.openapitools.codegen.plugin.CodeGenMojo -> [Help 1]

This PR is about to fix it.

@jmini jmini added this to the 4.0.2 milestone Jun 3, 2019
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 8c9a151 into OpenAPITools:master Jun 3, 2019
@wing328 wing328 mentioned this pull request Jun 3, 2019
4 tasks
wing328 added a commit that referenced this pull request Jun 4, 2019
wing328 added a commit that referenced this pull request Jun 4, 2019
wing328 added a commit that referenced this pull request Jun 4, 2019
…CI (#3087)

* test plugin in travis, move jobs to circle CI

* Revert "[maven-plugin] fix strictSpec parameter (#3071)"

This reverts commit 8c9a151.

* Revert "Revert "[maven-plugin] fix strictSpec parameter (#3071)""

This reverts commit c3e5723.

* test with jdk8
@jimschubert
Copy link
Member

@jmini

@wing328 and I were discussing this fix in chat. I was wondering, would you mind if we change the property to strictSpec so we aren't supporting two aliases for the same setting in Maven, Gradle, and CLI?

@jmini
Copy link
Member Author

jmini commented Jun 5, 2019

Yes as discussed in Gitter a solution might be to revert the change made here with the alias parameter but to rename:

private Boolean strictSpecBehavior;

To:

private Boolean strictSpec;

This will have the same effect.

jmini added a commit to jmini/openapi-generator that referenced this pull request Jun 5, 2019
jimschubert pushed a commit that referenced this pull request Jun 5, 2019
* Revert "[maven-plugin] fix strictSpec parameter (#3071)"

This reverts commit 8c9a151.

* [maven-plugin] fix strictSpec parameter without alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants