Skip to content

[Java] Replace "useNullForUnknownEnumValue" option with the nullable attribute #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 25, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • [Java] Replace "useNullForUnknownEnumValue" option with the nullable attribute

@wing328
Copy link
Member Author

wing328 commented Jul 26, 2019

Credits go to @phstudy (#1117)

@wing328
Copy link
Member Author

wing328 commented Jul 26, 2019

TODO: Add tests for Java client (OAS v3 spec)

@wing328 wing328 merged commit 8253c28 into master Jul 26, 2019
@wing328 wing328 deleted the java-nullable-enum branch July 26, 2019 01:49
@wing328
Copy link
Member Author

wing328 commented Jul 26, 2019

Upgrade Note

The option useNullForUnknownEnumValue has been removed.

Please use nullable (OAS v3) or x-nullable (OAS v2) for enum instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant