Skip to content

[Kotlin][Client] Added support for consuming OpenApi 3.0 nullable required fields #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlexanderEggers
Copy link
Contributor

Fixes #4651.

  • consumes the OpenApi 3.0 nullable field definition; if defined, even required fields will be nullable.
  • required-nullable fields won't have a default value. The field is still required to exist - only it's value is null.
  • added new kotlin-client sample to show the nullable-field changes
    • in the model "Pet" the field "name" is now nullable. In the yaml it is defined as a required nullable field.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10)

@AlexanderEggers
Copy link
Contributor Author

@wing328 This is the new PR for #4655. I guess I messed something up with my git client (just re-installed it) and that led to some confusing behaviour. Sorry about the mess. This PR should be fine now.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 467fb74 into OpenAPITools:master Dec 5, 2019
@wing328 wing328 added this to the 4.2.3 milestone Jan 31, 2020
@AlexanderEggers AlexanderEggers deleted the added-nullable-required-field-support branch April 2, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Kotlin] required yet nullable schema properties are not optional in generated models
2 participants