-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
[Kotlin][Client] Added Kotlinx Serialization for JVM/Retrofit2/OkHttp3&4 #6916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin][Client] Added Kotlinx Serialization for JVM/Retrofit2/OkHttp3&4 #6916
Conversation
@kuFEAR thanks for the PR. Can you please resolve the merge conflicts when you've time? |
Shippable CI failed with the following errors:
Looks like the cause is |
Oh, I'll fix multiplatform SafeEnum build today |
Now Shippable CI reports the following errors:
When you've time, please take another look. If you need help from us, let us know. |
@wing328 I'll wait kotlin update from this PR https://github.com/OpenAPITools/openapi-generator/pull/7149/files, now we have some overlaps in changes and double work |
@wing328 Also I want to add exact SerializeAdapter instead @ContextualSerializer for each custom properties, how I can extend CodegenProperty for that, and is it acceptable changes for generators in common? Now I can use only isPrimitiveType/isEnum/complexType and some times it works incorrect |
d06ea1d
to
15f3f59
Compare
Fix adapter naming Fix Retrofit ApiClient.kt for kotlin.serialization
…inx-converter 0.7.0
@wing328 @jimschubert Hi, can you re-run circleci build? as I notice it failed on downloading fastxml.jackson |
...rc/main/resources/kotlin-client/libraries/jvm-retrofit2/infrastructure/ApiClient.kt.mustache
Outdated
Show resolved
Hide resolved
…zation_jvm # Conflicts: # modules/openapi-generator/src/main/resources/kotlin-client/build.gradle.mustache # pom.xml # samples/client/petstore/kotlin-gson/build.gradle # samples/client/petstore/kotlin-gson/pom.xml # samples/client/petstore/kotlin-jackson/build.gradle # samples/client/petstore/kotlin-jackson/pom.xml # samples/client/petstore/kotlin-json-request-string/build.gradle # samples/client/petstore/kotlin-json-request-string/pom.xml # samples/client/petstore/kotlin-jvm-okhttp4-coroutines/build.gradle # samples/client/petstore/kotlin-jvm-okhttp4-coroutines/pom.xml # samples/client/petstore/kotlin-moshi-codegen/build.gradle # samples/client/petstore/kotlin-moshi-codegen/pom.xml # samples/client/petstore/kotlin-nonpublic/build.gradle # samples/client/petstore/kotlin-nonpublic/pom.xml # samples/client/petstore/kotlin-nullable/build.gradle # samples/client/petstore/kotlin-nullable/pom.xml # samples/client/petstore/kotlin-okhttp3/build.gradle # samples/client/petstore/kotlin-okhttp3/pom.xml # samples/client/petstore/kotlin-retrofit2-rx3/build.gradle # samples/client/petstore/kotlin-retrofit2-rx3/pom.xml # samples/client/petstore/kotlin-retrofit2/build.gradle # samples/client/petstore/kotlin-retrofit2/pom.xml # samples/client/petstore/kotlin-string/build.gradle # samples/client/petstore/kotlin-string/pom.xml # samples/client/petstore/kotlin-threetenbp/build.gradle # samples/client/petstore/kotlin-threetenbp/pom.xml # samples/client/petstore/kotlin-uppercase-enum/build.gradle # samples/client/petstore/kotlin/build.gradle # samples/client/petstore/kotlin/gradle/wrapper/gradle-wrapper.jar # samples/client/petstore/kotlin/gradlew # samples/client/petstore/kotlin/pom.xml
delete petstore/kotlin unit tests
@wing328 Hi! I have PR for some time in repo. Can you approve it? I think it will be really useful for many projects |
@kuFEAR thanks again for the PR. Let me try to review shortly.... |
@kuFEAR quickly went through it. looks good overall 👍 Have minor 2 questions. Free in the coming week to discuss it further? PM via Slack to discuss further. Have a nice weekend. |
As discussed, please recover the following deleted test files:
|
78b269a
to
54bcbc1
Compare
remove adding pom.xml to kotlin client samples
54bcbc1
to
7c3f170
Compare
All tests passed. I may file a PR later to make minor enhancements. Thanks again for the PR. |
@kuFEAR thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423 |
Added supporting for Kotlinx.serialization 1.1.0 on JVM with base set of JVM type serialize adapters, also update Kotlin 1.4.30 and Gradle wrapper 6.8.3
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*
. For Windows users, please run the script in Git BASH.master
@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)