Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Fixes regex pattern handling #20

Merged
merged 6 commits into from
Sep 29, 2022
Merged

Fixes regex pattern handling #20

merged 6 commits into from
Sep 29, 2022

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Sep 28, 2022

  • Fixes regex pattern handling
  • Adds testRegexWithoutTrailingSlashWorks + testRegexWithMultipleFlagsWorks as verification

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether added this to the 1.0.0 milestone Sep 28, 2022
@spacether spacether linked an issue Sep 28, 2022 that may be closed by this pull request
6 tasks
@spacether spacether merged commit 27cbe43 into master Sep 29, 2022
@spacether spacether deleted the 11-fix-regex-handling branch September 29, 2022 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Regex patterns without trailing slashes break Python client generation
1 participant